C++: Fix inconsistencies.

Author: MathiasVP

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll

@@ -766,7 +766,8 @@ private predicate sourceVariableIsGlobal(
     sourceVariableHasBaseAndIndex(sv, base, indirectionIndex) and
     irVar = base.getIRVariable() and
     irVar.getEnclosingIRFunction() = func and
-    global = irVar.getAst()
+    global = irVar.getAst() and
+    not irVar instanceof IRDynamicInitializationFlag
   )
 }
 

cpp/ql/test/library-tests/dataflow/dataflow-tests/dataflow-ir-consistency.expected

@@ -4,14 +4,6 @@ uniqueType
 uniqueNodeLocation
 missingLocation
 uniqueNodeToString
-| test.cpp:632:6:632:24 | Use of x indirection | Node should have one toString but has 2. |
-| test.cpp:632:6:632:24 | Use of x#init indirection | Node should have one toString but has 2. |
-| test.cpp:637:6:637:24 | Use of x indirection | Node should have one toString but has 2. |
-| test.cpp:637:6:637:24 | Use of x#init indirection | Node should have one toString but has 2. |
-| test.cpp:663:6:663:24 | Use of s indirection | Node should have one toString but has 2. |
-| test.cpp:663:6:663:24 | Use of s#init indirection | Node should have one toString but has 2. |
-| test.cpp:669:6:669:24 | Use of s indirection | Node should have one toString but has 2. |
-| test.cpp:669:6:669:24 | Use of s#init indirection | Node should have one toString but has 2. |
 missingToString
 parameterCallable
 localFlowIsLocal