Skip to content

Commit c4271c1

Browse files
committed
Python: add TODO comments
1 parent 40526fd commit c4271c1

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

python/ql/lib/semmle/python/ApiGraphs.qll

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -754,15 +754,21 @@ module API {
754754
dict.getItem(_) = item
755755
|
756756
// from `x` to `{ "key": x }`
757+
// TODO: once convenient, this should be done at a higher level than the AST,
758+
// at least at the CFG layer, to take splitting into account.
757759
rhs.(DataFlow::ExprNode).getNode().getNode() = item.getValue() and
758760
lbl = Label::subscript()
759761
or
760762
// from `"key"` to `{ "key": x }`
763+
// TODO: once convenient, this should be done at a higher level than the AST,
764+
// at least at the CFG layer, to take splitting into account.
761765
rhs.(DataFlow::ExprNode).getNode().getNode() = item.getKey() and
762766
lbl = Label::index()
763767
)
764768
or
765769
// list literals, from `x` to `[x]`
770+
// TODO: once convenient, this should be done at a higher level than the AST,
771+
// at least at the CFG layer, to take splitting into account.
766772
exists(PY::List list | list = pred.(DataFlow::ExprNode).getNode().getNode() |
767773
rhs.(DataFlow::ExprNode).getNode().getNode() = list.getAnElt() and
768774
lbl = Label::subscript()

0 commit comments

Comments
 (0)