Skip to content

Commit ce3ee65

Browse files
committed
python: remove getTree for now
1 parent 853857b commit ce3ee65

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

python/ql/lib/semmle/python/Concepts.qll

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -519,9 +519,6 @@ class XPathExecution extends DataFlow::Node {
519519
/** Gets the data flow node for the XPath expression being executed by this node. */
520520
DataFlow::Node getXPath() { result = range.getXPath() }
521521

522-
/** Gets a dataflow node for the tree in which the XPath expression is being evaluated. */
523-
DataFlow::Node getTree() { result = range.getTree() }
524-
525522
/**
526523
* Gets the name of this XPath expression execution, typically the name of an executing method.
527524
* This is used for nice alert messages and should include the module if possible.
@@ -544,9 +541,6 @@ module XPathExecution {
544541
/** Gets the data flow node for the XPath expression being executed by this node. */
545542
abstract DataFlow::Node getXPath();
546543

547-
/** Gets a dataflow node for the tree in which the XPath expression is being evaluated. */
548-
abstract DataFlow::Node getTree();
549-
550544
/**
551545
* Gets the name of this xpath expression execution, typically the name of an executing method.
552546
* This is used for nice alert messages and should include the module if possible.

python/ql/lib/semmle/python/frameworks/Libxml2.qll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ private module Libxml2 {
4040

4141
override DataFlow::Node getXPath() { result = this.getArg(0) }
4242

43-
// TODO: implement when we get call nodes
44-
override DataFlow::Node getTree() { none() }
45-
4643
override string getName() { result = "libxml2" }
4744
}
4845
}

python/ql/lib/semmle/python/frameworks/Lxml.qll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ private module Lxml {
6868

6969
override DataFlow::Node getXPath() { result in [this.getArg(0), this.getArgByName("_path")] }
7070

71-
// TODO: implement when we get call nodes
72-
override DataFlow::Node getTree() { none() }
73-
7471
override string getName() { result = "lxml.etree" }
7572
}
7673
}

0 commit comments

Comments
 (0)