Add new source kind to CsvValidation

atorralba · atorralba · commit e0b4c63a5368 · 2022-06-28T10:16:40.000+02:00
diff --git a/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll b/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll
@@ -647,7 +647,7 @@ module CsvValidation {
     or
     exists(string row, string kind | sourceModel(row) |
       kind = row.splitAt(";", 7) and
-      not kind = ["remote", "contentprovider", "android-widget"] and
+      not kind = ["remote", "contentprovider", "android-widget", "android-external-storage-dir"] and
       not kind.matches("qltest%") and
       msg = "Invalid kind \"" + kind + "\" in source model."
     )

Original file line number	Diff line number	Diff line change
`@@ -647,7 +647,7 @@ module CsvValidation {`
`647`	`647`	`or`
`648`	`648`	`exists(string row, string kind \| sourceModel(row) \|`
`649`	`649`	`kind = row.splitAt(";", 7) and`
`650`		`- not kind = ["remote", "contentprovider", "android-widget"] and`
	`650`	`+ not kind = ["remote", "contentprovider", "android-widget", "android-external-storage-dir"] and`
`651`	`651`	`not kind.matches("qltest%") and`
`652`	`652`	`msg = "Invalid kind \"" + kind + "\" in source model."`
`653`	`653`	`)`