Python: Fix ql4ql alerts

RasmusWL · RasmusWL · commit e0e978bd3eff · 2023-04-21T14:18:50.000+02:00
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
@@ -708,8 +708,8 @@ predicate dictStoreStep(CfgNode nodeFrom, DictionaryElementContent c, Node nodeT
   or
   // see https://docs.python.org/3.10/library/stdtypes.html#dict.setdefault
   exists(MethodCallNode call |
-    call.calls(nodeTo.(PostUpdateNode).getPreUpdateNode(), ["setdefault"]) and
-    call.getArg(0).asExpr().(StrConst).getText() = c.(DictionaryElementContent).getKey() and
+    call.calls(nodeTo.(PostUpdateNode).getPreUpdateNode(), "setdefault") and
+    call.getArg(0).asExpr().(StrConst).getText() = c.getKey() and
     nodeFrom = call.getArg(1)
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -708,8 +708,8 @@ predicate dictStoreStep(CfgNode nodeFrom, DictionaryElementContent c, Node nodeT`
`708`	`708`	`or`
`709`	`709`	`// see https://docs.python.org/3.10/library/stdtypes.html#dict.setdefault`
`710`	`710`	`exists(MethodCallNode call \|`
`711`		`- call.calls(nodeTo.(PostUpdateNode).getPreUpdateNode(), ["setdefault"]) and`
`712`		`- call.getArg(0).asExpr().(StrConst).getText() = c.(DictionaryElementContent).getKey() and`
	`711`	`+ call.calls(nodeTo.(PostUpdateNode).getPreUpdateNode(), "setdefault") and`
	`712`	`+ call.getArg(0).asExpr().(StrConst).getText() = c.getKey() and`
`713`	`713`	`nodeFrom = call.getArg(1)`
`714`	`714`	`)`
`715`	`715`	`}`