Skip to content

Commit e3fbaf5

Browse files
committed
Shared: prefer exists(var) instead of var = any(string s)
1 parent 1025400 commit e3fbaf5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsSpecific.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,5 +217,5 @@ predicate isExtraValidNoArgumentTokenInIdentifyingAccessPath(string name) {
217217
bindingset[name, argument]
218218
predicate isExtraValidTokenArgumentInIdentifyingAccessPath(string name, string argument) {
219219
name = ["Member"] and
220-
argument = any(string s)
220+
exists(argument)
221221
}

ruby/ql/lib/codeql/ruby/frameworks/data/internal/ApiGraphModelsSpecific.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@ predicate isPackageUsed(string package) {
5050
bindingset[package, type, path]
5151
API::Node getExtraNodeFromPath(string package, string type, AccessPath path, int n) {
5252
isRelevantFullPath(package, type, path) and
53-
package = any(string s) and // Allow any package name, see `isPackageUsed`.
53+
exists(package) and // Allow any package name, see `isPackageUsed`.
5454
type = "" and
5555
n = 0 and
5656
result = API::root()
5757
or
5858
// A row of form `;any;Method[foo]` should match any method named `foo`.
59-
package = any(string s) and
59+
exists(package) and
6060
type = "any" and
6161
n = 1 and
6262
exists(EntryPointFromAnyType entry |
@@ -164,5 +164,5 @@ predicate isExtraValidNoArgumentTokenInIdentifyingAccessPath(string name) {
164164
bindingset[name, argument]
165165
predicate isExtraValidTokenArgumentInIdentifyingAccessPath(string name, string argument) {
166166
name = ["Member", "Method"] and
167-
argument = any(string s)
167+
exists(argument)
168168
}

0 commit comments

Comments
 (0)