Skip to content

Commit ead0b65

Browse files
committed
Python: Fix fieldflow tests by increasing max-import-depth
1 parent a0d1cea commit ead0b65

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
semmle-extractor-options: --max-import-depth=3

python/ql/test/experimental/dataflow/fieldflow/test.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import sys
22
import os
33

4-
sys.path.append(os.path.dirname(os.path.dirname((__file__)))) # $ unresolved_call=os.path.dirname(..) unresolved_call=sys.path.append(..)
4+
sys.path.append(os.path.dirname(os.path.dirname((__file__)))) # $ unresolved_call=sys.path.append(..)
55
from testlib import expects
66

77
# These are defined so that we can evaluate the test code.
@@ -210,40 +210,40 @@ def test_global_scope():
210210

211211
# apparently these if statements below makes a difference :O
212212
# but one is not enough
213-
cond = os.urandom(1)[0] > 128 # $ unresolved_call=os.urandom(..)
213+
cond = os.urandom(1)[0] > 128
214214

215215
if cond:
216216
pass
217217

218218
# def test_constructor_assign():
219-
obj2 = MyObj(SOURCE) # $ unresolved_call=MyObj(..)
220-
SINK(obj2.foo) # $ unresolved_call=SINK(..) MISSING: flow="SOURCE, l:-1 -> obj2.foo"
219+
obj2 = MyObj(SOURCE)
220+
SINK(obj2.foo) # $ flow="SOURCE, l:-1 -> obj2.foo"
221221

222222
if cond:
223223
pass
224224

225225
# def test_constructor_assign():
226-
obj2 = MyObj(SOURCE) # $ unresolved_call=MyObj(..)
227-
SINK(obj2.foo) # $ unresolved_call=SINK(..) MISSING: flow="SOURCE, l:-1 -> obj2.foo"
226+
obj2 = MyObj(SOURCE)
227+
SINK(obj2.foo) # $ flow="SOURCE, l:-1 -> obj2.foo"
228228

229229
# def test_constructor_assign_kw():
230-
obj3 = MyObj(foo=SOURCE) # $ unresolved_call=MyObj(..)
231-
SINK(obj3.foo) # $ unresolved_call=SINK(..) MISSING: flow="SOURCE, l:-1 -> obj3.foo"
230+
obj3 = MyObj(foo=SOURCE)
231+
SINK(obj3.foo) # $ flow="SOURCE, l:-1 -> obj3.foo"
232232

233233
# def test_fields():
234-
SINK(fields_with_local_flow(SOURCE)) # $ unresolved_call=fields_with_local_flow(..) unresolved_call=SINK(..) MISSING: flow="SOURCE -> fields_with_local_flow(..)"
234+
SINK(fields_with_local_flow(SOURCE)) # $ flow="SOURCE -> fields_with_local_flow(..)"
235235

236236
# --------------------------------------
237237
# method calls _after_ those ifs
238238
# --------------------------------------
239239

240240
# def test_indirect_assign_method():
241-
myobj2 = MyObj("OK") # $ unresolved_call=MyObj(..)
242-
myobj2.setFoo(SOURCE) # $ unresolved_call=myobj2.setFoo(..)
243-
SINK(myobj2.foo) # $ unresolved_call=SINK(..) MISSING: flow="SOURCE, l:-1 -> myobj2.foo"
241+
myobj2 = MyObj("OK")
242+
myobj2.setFoo(SOURCE)
243+
SINK(myobj2.foo) # $ flow="SOURCE, l:-1 -> myobj2.foo"
244244

245245
# def test_nested_obj_method():
246246
x2 = SOURCE
247-
a2 = NestedObj() # $ unresolved_call=NestedObj()
248-
a2.getObj().foo = x2 # $ unresolved_call=a2.getObj()
249-
SINK(a2.obj.foo) # $ unresolved_call=SINK(..) MISSING: flow="SOURCE, l:-3 -> a2.obj.foo"
247+
a2 = NestedObj()
248+
a2.getObj().foo = x2
249+
SINK(a2.obj.foo) # $ flow="SOURCE, l:-3 -> a2.obj.foo"

0 commit comments

Comments
 (0)