Skip to content

Commit ec97cdc

Browse files
committed
Allow NonKeyCiphers to include truncated SHA-512 MDs in Forge JS library.
1 parent 15d5ad7 commit ec97cdc

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* The Forge module in `CryptoLibraries.qll` now correctly classifies SHA-512/224,
5+
* SHA-512/256, and SHA-512/384 hashes used in message digests as NonKeyCiphers.

javascript/ql/lib/semmle/javascript/frameworks/CryptoLibraries.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,10 @@ private module Forge {
627627
// require("forge").md.md5.create().update('The quick brown fox jumps over the lazy dog');
628628
this =
629629
getAnImportNode().getMember("md").getMember(algorithmName).getMember("create").getACall()
630+
or
631+
// require("forge").sha512.sha256.create().update('The quick brown fox jumps over the lazy dog');
632+
this =
633+
getAnImportNode().getMember("md").getMember(algorithmName).getAMember().getMember("create").getACall()
630634
)
631635
}
632636

0 commit comments

Comments
 (0)