Skip to content

Commit f1144b9

Browse files
committed
Swift: small TypeRepr visit rewording
1 parent 48c71c9 commit f1144b9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

swift/extractor/visitors/SwiftVisitor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class SwiftVisitor : private SwiftDispatcher {
2727
void visit(swift::Pattern* pattern) override { patternVisitor.visit(pattern); }
2828
void visit(swift::TypeBase* type) override { typeVisitor.visit(type); }
2929
void visit(swift::TypeRepr* typeRepr, swift::Type type) override {
30-
typeVisitor.visit(*typeRepr, type);
30+
emit(typeVisitor.translateTypeRepr(*typeRepr, type));
3131
}
3232

3333
DeclVisitor declVisitor{*this};

swift/extractor/visitors/TypeVisitor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ void TypeVisitor::visit(swift::TypeBase* type) {
88
dispatcher_.emit(TypesTrap{label, type->getString(), canonicalLabel});
99
}
1010

11-
void TypeVisitor::visit(const swift::TypeRepr& typeRepr, swift::Type type) {
11+
codeql::TypeRepr TypeVisitor::translateTypeRepr(const swift::TypeRepr& typeRepr, swift::Type type) {
1212
auto entry = dispatcher_.createEntry(typeRepr);
1313
entry.type = dispatcher_.fetchLabel(type);
14-
dispatcher_.emit(entry);
14+
return entry;
1515
}
1616

1717
void TypeVisitor::visitProtocolType(swift::ProtocolType* type) {

swift/extractor/visitors/TypeVisitor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class TypeVisitor : public TypeVisitorBase<TypeVisitor> {
99
using TypeVisitorBase<TypeVisitor>::TypeVisitorBase;
1010

1111
void visit(swift::TypeBase* type);
12-
void visit(const swift::TypeRepr& typeRepr, swift::Type type);
12+
codeql::TypeRepr translateTypeRepr(const swift::TypeRepr& typeRepr, swift::Type type);
1313

1414
void visitProtocolType(swift::ProtocolType* type);
1515
void visitEnumType(swift::EnumType* type);

0 commit comments

Comments
 (0)