Skip to content

Commit f2ec513

Browse files
aibaarsnickrolfe
andauthored
Apply suggestions from code review
Co-authored-by: Nick Rolfe <[email protected]>
1 parent 747c7f6 commit f2ec513

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

ruby/ql/lib/codeql/ruby/InclusionTests.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class InclusionTest extends DataFlow::Node instanceof InclusionTest::Range {
3838
*/
3939
module InclusionTest {
4040
/**
41-
* A expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
41+
* An expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
4242
*
4343
* Note that this also includes calls to the array method named `include?`.
4444
*/

ruby/ql/lib/codeql/ruby/StringOps.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ module StringOps {
104104
}
105105

106106
/**
107-
* A expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
107+
* An expression that is equivalent to `A.include?(B)` or `!A.include?(B)`.
108108
* Note that this class is equivalent to `InclusionTest`, which also matches
109109
* inclusion tests on array objects.
110110
*/

ruby/ql/src/queries/security/cwe-020/examples/IncompleteUrlSubstringSanitization_BAD1.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@ def index
44
# BAD: the host of `url` may be controlled by an attacker
55
if url.include?("example.com")
66
redirect_to url
7+
end
78
end
89
end

0 commit comments

Comments
 (0)