Skip to content

Commit f857cd1

Browse files
committed
Swift: add comments about SwiftDispatcher lifetime
1 parent acbe9ff commit f857cd1

File tree

5 files changed

+5
-0
lines changed

5 files changed

+5
-0
lines changed

swift/extractor/visitors/DeclVisitor.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ namespace codeql {
77

88
class DeclVisitor : public swift::DeclVisitor<DeclVisitor> {
99
public:
10+
// SwiftDispatcher should outlive the DeclVisitor
1011
DeclVisitor(SwiftDispatcher& dispatcher) : dispatcher(dispatcher) {}
1112

1213
template <typename E>

swift/extractor/visitors/ExprVisitor.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ namespace codeql {
77

88
class ExprVisitor : public swift::ExprVisitor<ExprVisitor> {
99
public:
10+
// SwiftDispatcher should outlive the ExprVisitor
1011
ExprVisitor(SwiftDispatcher& dispatcher) : dispatcher(dispatcher) {}
1112

1213
template <typename E>

swift/extractor/visitors/PatternVisitor.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class PatchedPatternVisitor : public swift::PatternVisitor<ImplClass, PatternRet
2020

2121
class PatternVisitor : public PatchedPatternVisitor<PatternVisitor> {
2222
public:
23+
// SwiftDispatcher should outlive the PatternVisitor
2324
PatternVisitor(SwiftDispatcher& dispatcher) : dispatcher(dispatcher) {}
2425

2526
template <typename E>

swift/extractor/visitors/StmtVisitor.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class PatchedStmtVisitor : public swift::StmtVisitor<ImplClass, StmtRetTy, Args.
2121

2222
class StmtVisitor : public PatchedStmtVisitor<StmtVisitor> {
2323
public:
24+
// SwiftDispatcher should outlive the StmtVisitor
2425
StmtVisitor(SwiftDispatcher& dispatcher) : dispatcher(dispatcher) {}
2526

2627
template <typename E>

swift/extractor/visitors/TypeVisitor.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ namespace codeql {
77

88
class TypeVisitor : public swift::TypeVisitor<TypeVisitor> {
99
public:
10+
// SwiftDispatcher should outlive the TypeVisitor
1011
TypeVisitor(SwiftDispatcher& dispatcher) : dispatcher(dispatcher) {}
1112

1213
template <typename E>

0 commit comments

Comments
 (0)