Skip to content

Commit fcc4c91

Browse files
committed
C++: More responding to comments.
1 parent daf7d1b commit fcc4c91

File tree

1 file changed

+7
-2
lines changed
  • cpp/ql/lib/semmle/code/cpp/models/implementations

1 file changed

+7
-2
lines changed

cpp/ql/lib/semmle/code/cpp/models/implementations/Iterator.qll

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,15 +214,20 @@ private class IteratorBinaryArithmeticMemberOperatorModel extends IteratorBinary
214214
/**
215215
* A (member or non-member) `operator+` or `operator-` function for an iterator type.
216216
*/
217-
class IteratorBinaryAddOperator extends Function {
218-
IteratorBinaryAddOperator() {
217+
class IteratorBinaryArithmeticOperator extends Function {
218+
IteratorBinaryArithmeticOperator() {
219219
this instanceof IteratorAddNonMemberOperator or
220+
this instanceof IteratorSubNonMemberOperator or
220221
this instanceof IteratorBinaryArithmeticMemberOperator
221222
}
222223
}
223224

224225
/**
225226
* A non-member `operator-` function that takes a pointer difference type as its second argument.
227+
*
228+
* Note that this class _only_ matches non-member functions. To find both
229+
* non-member and member versions, use `IteratorBinaryArithmeticOperator` (which also
230+
* includes `operator+` versions).
226231
*/
227232
class IteratorSubNonMemberOperator extends Operator {
228233
IteratorSubNonMemberOperator() {

0 commit comments

Comments
 (0)