C++: Fix expensive getWideCharType().

geoffw0 · geoffw0 · commit ff3bedcab932 · 2022-03-17T14:41:57.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/models/interfaces/FormattingFunction.qll b/cpp/ql/lib/semmle/code/cpp/models/interfaces/FormattingFunction.qll
@@ -97,7 +97,7 @@ abstract class FormattingFunction extends ArrayFunction, TaintFunction {
     result.getSize() > 1
     or
     not getFormatCharType().getSize() > 1 and
-    result = getAFormatterWideTypeOrDefault() // may have more than one result
+    result = pragma[only_bind_out](getAFormatterWideTypeOrDefault()) // may have more than one result
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ abstract class FormattingFunction extends ArrayFunction, TaintFunction {`
`97`	`97`	`result.getSize() > 1`
`98`	`98`	`or`
`99`	`99`	`not getFormatCharType().getSize() > 1 and`
`100`		`- result = getAFormatterWideTypeOrDefault() // may have more than one result`
	`100`	`+ result = pragma[only_bind_out](getAFormatterWideTypeOrDefault()) // may have more than one result`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`/**`