Skip to content

Commit 5ef95ff

Browse files
Copilotdiasbruno
andauthored
Polish provider fallback and routing compat docs
Agent-Logs-Url: https://github.com/cl-sdk/io.github.cl-sdk.wst/sessions/9199f57b-a9c4-424c-9c46-02842ca3d950 Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
1 parent 6221583 commit 5ef95ff

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

feature-flag/routing.lisp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Example:
4444
(request-data-key :feature-flag-evaluation-context))
4545
"Create a feature-flag client composed with request-scoped context.
4646
OBJECT-OF-INTEREST defaults to REQUEST and is used by RESOLVE-PROVIDER.
47-
NAME is accepted for backward compatibility and currently unused.
47+
NAME is accepted for backward compatibility; it was used by the removed CREATE-CLIENT API and is currently unused.
4848
Example:
4949
(client-for-request request :domain \"payments\" :evaluation-context '(:app \"checkout\"))
5050
=> #<CLIENT ...>"

t/feature-flag-tests.lisp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@
9494

9595
(defmethod resolve-provider ((holder provider-holder) domain)
9696
(or (and domain (cdr (assoc domain (provider-holder-domain-providers holder) :test #'equal)))
97-
(provider-holder-default-provider holder)))
97+
(provider-holder-default-provider holder)
98+
(call-next-method)))
9899

99100
(test provider-without-resolver-returns-default-and-provider-not-ready-error
100101
(let* ((client (acquire-client (make-instance 'provider :name "base")))

0 commit comments

Comments
 (0)