Skip to content

Commit 9f7a127

Browse files
Copilotdiasbruno
andauthored
Apply OpenFeature style review fixes
Agent-Logs-Url: https://github.com/cl-sdk/io.github.cl-sdk.wst/sessions/9801b077-a57b-45cc-8fe7-99ea56807d5f Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
1 parent 01d01f9 commit 9f7a127

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

openfeature/package.lisp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ Planned for later phases:
126126

127127
(defun %ensure-context (context where)
128128
(unless (%plist-even-p context)
129-
(error "~a must be a plist (even-length list)." where))
129+
(error "~A must be a plist (even-length list)." where))
130130
context)
131131

132132
(defun merge-evaluation-contexts (&rest contexts)

openfeature/routing.lisp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
(in-package #:io.github.cl-sdk.wst.openfeature.routing)
1010

1111
(defun wrap-openfeature-context (&key
12-
(context-fn (lambda (_request) nil))
12+
(context-fn (lambda (request)
13+
(declare (ignore request))
14+
nil))
1315
(request-data-key :openfeature-evaluation-context))
1416
"Create a before-middleware that injects request-scoped OpenFeature context."
1517
(check-type request-data-key keyword)

t/openfeature-routing-tests.lisp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
(let* ((request (io.github.cl-sdk.wst.routing:make-request :uri "/" :method :GET))
2929
(response (io.github.cl-sdk.wst.routing:make-response))
3030
(middleware (wrap-openfeature-context
31-
:context-fn (lambda (_request)
32-
(declare (ignore _request))
31+
:context-fn (lambda (request)
32+
(declare (ignore request))
3333
'(:tenant "acme" :plan "pro"))))
3434
(result (funcall middleware request response)))
3535
(is (eq :continue (car result)))
@@ -42,8 +42,8 @@
4242
(request (io.github.cl-sdk.wst.routing:make-request :uri "/" :method :GET))
4343
(response (io.github.cl-sdk.wst.routing:make-response))
4444
(middleware (wrap-openfeature-context
45-
:context-fn (lambda (_request)
46-
(declare (ignore _request))
45+
:context-fn (lambda (request)
46+
(declare (ignore request))
4747
'(:tenant "acme" :shared :request)))))
4848
(set-provider provider)
4949
(funcall middleware request response)

0 commit comments

Comments
 (0)