Merge pull request #127 from CNugteren/mem_used_calculation

Updated the computation of matrix memory requirements

Author: Timmy

src/library/blas/generic/common.c

@@ -664,10 +664,10 @@ checkMatrixSizes(
         }
     }
 
-    //  It is possible to allocate a buffer, and set up lda & ldb such that it looks like it will access outside of the allocated buffer, but if
-    //  M & N are kept small enough, no out of bounds access will occur.  Compensate for the offset values and the unused tail memory caused by lda & ldb.
-    //  Ex: BuffSize=6 floats, M=1, N=2, lda=ldb=3, offA = 0, offB = 2 :  |A[0,0]|unused|B[0,0]|A[0,1]|unused|B[0,1]|
-    memUsed = (( offA + matrSize ) > unusedTail) ? offA + matrSize - unusedTail: 0;
+    // Calculates the memory required. Note that 'matrSize' already takes into account the fact that
+    // there might be an unused tail, i.e. the elements between lda and M in the last column if
+    // column major is used or between lda and N in the last row if row major is used.
+    memUsed = offA + matrSize;
     if (( memUsed > memSize ) || (offA + matrSize < offA)) {
         switch( err )
         {
@@ -753,10 +753,10 @@ checkBandedMatrixSizes(
         }
     }
 
-    //  It is possible to allocate a buffer, and set up lda & ldb such that it looks like it will access outside of the allocated buffer, but if
-    //  M & N are kept small, no out of bounds access will occur.  Compensate for the offset values and the unused tail memory caused by lda & ldb.
-    //  Ex: BuffSize=6 floats, M=1, N=2, lda=ldb=3, offA = 0, offB = 2 :  |A[0,0]|unused|B[0,0]|A[0,1]|unused|B[0,1]|
-    memUsed = (( offA + matrSize ) > unusedTail) ? offA + matrSize - unusedTail: 0;
+    // Calculates the memory required. Note that 'matrSize' already takes into account the fact that
+    // there might be an unused tail, i.e. the elements between lda and M in the last column if
+    // column major is used or between lda and N in the last row if row major is used.
+    memUsed = offA + matrSize;
     if (memUsed > memSize) {
         switch( err )
         {