Skip to content

Commit 8b3fee5

Browse files
committed
language-utils: remove check for navigatory == type of undefined
1 parent 640a0bb commit 8b3fee5

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

client/utils/language-utils.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import { getPreferredLanguage } from './language-utils';
22

33
describe('getPreferredLanguage', () => {
4-
const originalNavigator = global.navigator;
4+
const originalNavigator = window.navigator;
55

66
afterEach(() => {
7-
global.navigator = originalNavigator;
7+
window.navigator = originalNavigator;
88
});
99

1010
const mockNavigator = (language: string, languages: string[] = []) => {
11-
global.navigator = {
11+
window.navigator = {
1212
...originalNavigator,
1313
language,
1414
languages
@@ -17,15 +17,15 @@ describe('getPreferredLanguage', () => {
1717

1818
describe('when navigator is undefined', () => {
1919
it('returns the default language', () => {
20-
const oldNavigator = global.navigator;
20+
const oldNavigator = window.navigator;
2121

2222
// @ts-expect-error TS2790: The operand of a 'delete' operator must be optional
23-
delete global.navigator;
23+
delete window.navigator;
2424

2525
const result = getPreferredLanguage(['en', 'fr'], 'en');
2626
expect(result).toBe('en');
2727

28-
global.navigator = oldNavigator;
28+
window.navigator = oldNavigator;
2929
});
3030
});
3131

client/utils/language-utils.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ export function getPreferredLanguage(
66
supportedLanguages: string[] = [],
77
defaultLanguage: string = 'en'
88
): string | undefined {
9-
if (typeof navigator === 'undefined') {
9+
const { navigator } = window;
10+
11+
if (!navigator) {
1012
return defaultLanguage;
1113
}
1214

0 commit comments

Comments
 (0)