clippy: explicit_iter_loop

Author: little-dude

src/app/macros.rs

@@ -98,7 +98,7 @@ macro_rules! _handle_group_reqs{
     ($me:ident, $arg:ident) => ({
         use args::AnyArg;
         debugln!("_handle_group_reqs!;");
-        for grp in $me.groups.iter() {
+        for grp in &$me.groups {
             let found = if grp.args.contains(&$arg.name()) {
                 if let Some(ref reqs) = grp.requires {
                     debugln!("_handle_group_reqs!: Adding {:?} to the required list", reqs);

src/app/parser.rs

@@ -1853,7 +1853,7 @@ impl<'a, 'b> Parser<'a, 'b>
         debugln!("Parser::find_subcommand: sc={}", sc);
         debugln!("Parser::find_subcommand: Currently in Parser...{}",
                  self.meta.bin_name.as_ref().unwrap());
-        for s in self.subcommands.iter() {
+        for s in &self.subcommands {
             if s.p.is_bin_name(sc) {
                 return Some(s);
             }

src/args/group.rs

@@ -472,7 +472,7 @@ impl<'a> From<&'a BTreeMap<Yaml, Yaml>> for ArgGroup<'a> {
             b
         };
 
-        for (k, v) in group_settings.iter() {
+        for (k, v) in group_settings {
             a = match k.as_str().unwrap() {
                 "required" => a.required(v.as_bool().unwrap()),
                 "multiple" => a.multiple(v.as_bool().unwrap()),