Bug fix/version handling (#3)

madara-uchihaaa · web-flow · commit 293ad98182df · 2025-07-01T16:27:10.000+05:30
* Update version to 0.1.2 in pyproject.toml, __init__.py, and uv.lock; modify endpoint in AppDefinitionClient and enhance error logging in client methods

Signed-off-by: Rishabh Verma &lt;rishabh.v@clappia.com&gt;

* Update version to 0.1.4 in pyproject.toml, __init__.py, and uv.lock

Signed-off-by: Rishabh Verma &lt;rishabh.v@clappia.com&gt;

---------

Signed-off-by: Rishabh Verma &lt;rishabh.v@clappia.com&gt;
diff --git a/clappia_tools/__init__.py b/clappia_tools/__init__.py
@@ -9,7 +9,7 @@
 from .client.app_management_client import AppManagementClient
 from .client.submission_client import SubmissionClient
 
-__version__ = "0.1.1"
+__version__ = "0.1.4"
 __all__ = ["ClappiaClient", "AppDefinitionClient", "AppManagementClient", "SubmissionClient"]
 
 
diff --git a/clappia_tools/client/app_definition_client.py b/clappia_tools/client/app_definition_client.py
@@ -47,13 +47,15 @@ def get_definition(self, app_id: str, language: str = "en",
 
         success, error_message, response_data = self.api_utils.make_request(
             method="GET",
-            endpoint="appdefinition-external/getAppDefinition",
+            endpoint="appdefinitionv2/getAppDefinition",
             params=params,
         )
 
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
 
+
         app_info = {
             "appId": response_data.get("appId") if response_data else None,
             "version": response_data.get("version") if response_data else None,
diff --git a/clappia_tools/client/app_management_client.py b/clappia_tools/client/app_management_client.py
@@ -87,7 +87,9 @@ def create_app(self, app_name: str, requesting_user_email_address: str,
         )
 
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
+        
 
         app_id = response_data.get("appId") if response_data else None
         app_url = response_data.get("appUrl") if response_data else None
@@ -259,8 +261,10 @@ def add_field(self, app_id: str, requesting_user_email_address: str,
         )
         
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
         
+        
         field_name = response_data.get("fieldName") if response_data else None
         result = f"Successfully added field.\nField Name: {field_name}\n\nFULL RESPONSE:\n{json.dumps(response_data, indent=2)}"
         return result
@@ -445,6 +449,7 @@ def update_field(self, app_id: str, requesting_user_email_address: str, field_na
         )
 
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
         
         updated_properties = []
diff --git a/clappia_tools/client/submission_client.py b/clappia_tools/client/submission_client.py
@@ -14,7 +14,7 @@ class SubmissionClient(BaseClappiaClient):
     editing, retrieving, and managing submission ownership and status.
     """
 
-    def create_submission(self, app_id: str, data: Dict[str, Any], email: str) -> str:
+    def create_submission(self, app_id: str, data: Dict[str, Any], requesting_user_email_address: str) -> str:
         """Creates a new submission in a Clappia application with specified field data.
 
         Submits form data to create a new record in the specified Clappia app.
@@ -23,7 +23,7 @@ def create_submission(self, app_id: str, data: Dict[str, Any], email: str) -> st
         Args:
             app_id: Application ID in uppercase letters and numbers format (e.g., MFX093412). Use this to specify which Clappia app to create the submission in.
             data: Dictionary of field data to submit. Keys should match field names from the app definition, values should match expected field types. Example: {"employee_name": "John Doe", "department": "Engineering", "salary": 75000, "start_date": "20-02-2025"}.
-            email: Email address of the user creating the submission. This user becomes the submission owner and must have access to the specified app. Must be a valid email format.
+            requesting_user_email_address: Email address of the user creating the submission. This user becomes the submission owner and must have access to the specified app. Must be a valid email format.
 
         Returns:
             str: Formatted response with submission details and status
@@ -32,11 +32,11 @@ def create_submission(self, app_id: str, data: Dict[str, Any], email: str) -> st
         if not is_valid:
             return f"Error: Invalid app_id - {error_msg}"
 
-        if not email or not email.strip():
-            return "Error: email is required and cannot be empty"
+        if not requesting_user_email_address or not requesting_user_email_address.strip():
+            return "Error: requesting_user_email_address is required and cannot be empty"
 
-        if not ClappiaInputValidator.validate_email(email):
-            return "Error: email must be a valid email address"
+        if not ClappiaInputValidator.validate_email(requesting_user_email_address):
+            return "Error: requesting_user_email_address must be a valid email address"
 
         if not isinstance(data, dict):
             return "Error: data must be a dictionary"
@@ -51,19 +51,20 @@ def create_submission(self, app_id: str, data: Dict[str, Any], email: str) -> st
         payload = {
             "workplaceId": self.api_utils.workplace_id,
             "appId": app_id.strip(),
-            "requestingUserEmailAddress": email.strip(),
+            "requestingUserEmailAddress": requesting_user_email_address.strip(),
             "data": data,
         }
 
         logger.info(
-            f"Creating submission for app_id: {app_id} with data: {data} and email: {email}"
+            f"Creating submission for app_id: {app_id} with data: {data} and requesting_user_email_address: {requesting_user_email_address}"
         )
 
         success, error_message, response_data = self.api_utils.make_request(
             method="POST", endpoint="submissions/create", data=payload
         )
 
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
 
         submission_id = response_data.get("submissionId") if response_data else None
@@ -72,13 +73,13 @@ def create_submission(self, app_id: str, data: Dict[str, Any], email: str) -> st
             "submissionId": submission_id,
             "status": "created",
             "appId": app_id,
-            "owner": email,
+            "owner": requesting_user_email_address,
             "fieldsSubmitted": len(data),
         }
 
         return f"Successfully created submission:\n\nSUMMARY:\n{json.dumps(submission_info, indent=2)}\n\nFULL RESPONSE:\n{json.dumps(response_data, indent=2)}"
 
-    def edit_submission(self, app_id: str, submission_id: str, data: Dict[str, Any], email: str) -> str:
+    def edit_submission(self, app_id: str, submission_id: str, data: Dict[str, Any], requesting_user_email_address: str) -> str:
         """Edits an existing Clappia submission by updating specified field values.
 
         Modifies field data in an existing submission record while preserving other field values.
@@ -88,7 +89,7 @@ def edit_submission(self, app_id: str, submission_id: str, data: Dict[str, Any],
             app_id: Application ID in uppercase letters and numbers format (e.g., MFX093412). Use this to specify which Clappia app contains the submission.
             submission_id: Unique identifier of the submission to update (e.g., HGO51464561). This identifies the specific submission record to modify.
             data: Dictionary of field data to update. Keys should match field names from the app definition, values should match expected field types. Only specified fields will be updated. Example: {"employee_name": "Jane Doe", "department": "Marketing", "salary": 80000, "start_date": "20-02-2025"}.
-            email: Email address of the user requesting the edit. This user must have permission to modify the submission. Must be a valid email format.
+            requesting_user_email_address: Email address of the user requesting the edit. This user must have permission to modify the submission. Must be a valid email format.
 
         Returns:
             str: Formatted response with edit details and status
@@ -101,11 +102,11 @@ def edit_submission(self, app_id: str, submission_id: str, data: Dict[str, Any],
         if not is_valid:
             return f"Error: Invalid submission_id - {error_msg}"
 
-        if not email or not email.strip():
-            return "Error: email is required and cannot be empty"
+        if not requesting_user_email_address or not requesting_user_email_address.strip():
+            return "Error: requesting_user_email_address is required and cannot be empty"
 
-        if not ClappiaInputValidator.validate_email(email):
-            return "Error: email must be a valid email address"
+        if not ClappiaInputValidator.validate_email(requesting_user_email_address):
+            return "Error: requesting_user_email_address must be a valid email address"
 
         if not isinstance(data, dict):
             return "Error: data must be a dictionary"
@@ -121,25 +122,26 @@ def edit_submission(self, app_id: str, submission_id: str, data: Dict[str, Any],
             "workplaceId": self.api_utils.workplace_id,
             "appId": app_id.strip(),
             "submissionId": submission_id.strip(),
-            "requestingUserEmailAddress": email.strip(),
+            "requestingUserEmailAddress": requesting_user_email_address.strip(),
             "data": data,
         }
 
         logger.info(
-            f"Editing submission {submission_id} for app_id: {app_id} with data: {data} and email: {email}"
+            f"Editing submission {submission_id} for app_id: {app_id} with data: {data} and requesting_user_email_address: {requesting_user_email_address}"
         )
 
         success, error_message, response_data = self.api_utils.make_request(
             method="POST", endpoint="submissions/edit", data=payload
         )
 
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
 
         edit_info = {
             "submissionId": submission_id,
             "appId": app_id,
-            "requestingUser": email,
+            "requestingUser": requesting_user_email_address,
             "fieldsUpdated": len(data),
             "updatedFields": list(data.keys()),
             "status": "updated",
@@ -204,6 +206,7 @@ def update_owners(self, app_id: str, submission_id: str, requesting_user_email_a
         )
 
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
 
         owners_info = {
@@ -281,6 +284,7 @@ def update_status(self, app_id: str, submission_id: str, requesting_user_email_a
         )
 
         if not success:
+            logger.error(f"Error: {error_message}")
             return f"Error: {error_message}"
 
         status_info = {
diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "clappia-tools"
-version = "0.1.1"
+version = "0.1.4"
 description = "Python client for Clappia API integration"
 readme = "README.md"
 requires-python = ">=3.10"
diff --git a/uv.lock b/uv.lock
