Nix: Mark clash-ffi broken on the GHC versions it does not work on

Author: rowanG077

.github/workflows/nix.yml

@@ -80,6 +80,11 @@ jobs:
             "clash-term",
             "clash-testsuite"
         ]
+        exclude:
+          - ghc: ghc9103
+            package: clash-ffi
+          - ghc: ghc984
+            package: clash-ffi
     needs: packages_common
     steps:
       - uses: actions/checkout@v4

nix/overlay-ghc910.nix

@@ -1,7 +1,7 @@
 { pkgs }:
 final: prev:
 let
-  inherit (pkgs.haskell.lib) doJailbreak dontCheck markUnbroken;
+  inherit (pkgs.haskell.lib) overrideCabal doJailbreak dontCheck markUnbroken;
 in
 {
   # Use an older version than the default in nixpkgs. Since rewrite-inspector
@@ -17,4 +17,9 @@ in
 
   # An ipv6 test fails on CI. Most likely due to missing kernel support?
   network  = dontCheck prev.network;
+
+  # Broken on GHC > 9.8.3 see clash-ffi cabal file for details
+  clash-ffi = overrideCabal prev.clash-ffi (drv: {
+    broken = true;
+  });
 }

nix/overlay-ghc98.nix

@@ -1,7 +1,7 @@
 { pkgs }:
 final: prev:
 let
-  inherit (pkgs.haskell.lib) doJailbreak markUnbroken;
+  inherit (pkgs.haskell.lib) overrideCabal doJailbreak markUnbroken;
 in
 {
   # Use an older version than the default in nixpkgs. Since rewrite-inspector
@@ -21,4 +21,9 @@ in
 
   # singletons-th 3.3 requires th-desugar 1.16
   th-desugar = prev.callHackage "th-desugar" "1.16" { };
+
+  # Broken on GHC > 9.10.1 see clash-ffi cabal file for details
+  clash-ffi = overrideCabal prev.clash-ffi (drv: {
+    broken = true;
+  });
 }

nix/overlay.nix

@@ -222,9 +222,9 @@ let
 
   haskellOverlays =
     prev.lib.composeManyExtensions [
-      ghcOverlay
       haskellExternalPackages
       haskellInternalPackages
+      ghcOverlay
     ];
 in
 {