Skip to content

Commit 480a718

Browse files
committed
update flask_limiter
1 parent f0f96e3 commit 480a718

File tree

4 files changed

+55
-18
lines changed

4 files changed

+55
-18
lines changed

Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ flasgger = "~=0.9.3"
1212
flask-marshmallow = "~=0.10.1"
1313
Flask = "~=2.0.0"
1414
Flask-Cors = "~=3.0.8"
15-
Flask-Limiter = "~=1.0.1"
15+
Flask-Limiter = "~=3.2.0"
1616
gunicorn = "~=19.9.0"
1717
sqlalchemy = "~=1.3.13"
1818
flask-sqlalchemy = "~=2.5.0"

Pipfile.lock

Lines changed: 50 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
from blueprints import v0, main
44
from docs import create_docs
55
from flask_limiter import Limiter
6-
from common.helpers import get_request_origin_identifier, make_error_object, respond
6+
from flask_limiter.util import get_remote_address
7+
from common.helpers import make_error_object, respond
78
from common.db_schema import db
89
from common.schemas import *
910
from auth import db_connection_string
@@ -25,8 +26,8 @@ def create_app(config_filename=None):
2526
if config_filename:
2627
app.config.from_pyfile(config_filename)
2728

28-
limiter = Limiter(app, default_limits=[
29-
"25/hour", "5/minute"], key_func=get_request_origin_identifier, headers_enabled=True)
29+
limiter = Limiter(get_remote_address, app=app, default_limits=[
30+
"25/hour", "5/minute"], headers_enabled=True)
3031

3132
app.register_blueprint(v0.blueprint, url_prefix='/v0')
3233
app.register_blueprint(main.main_pages)

common/helpers.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,6 @@ def get_request_body(request):
195195
"""
196196
return request.get_json()
197197

198-
def get_request_origin_identifier():
199-
user_id_parts = get_api_user_id().split("|")
200-
return flask_limiter.util.get_remote_address() + get_api_client_id() + user_id_parts[1] if len(user_id_parts) > 2 else ""
201-
202198

203199
def get_api_client_id():
204200
"""Returns a string to group API calls together for the purposes of ratelimiting

0 commit comments

Comments
 (0)