Update - codacy and scripts fixes

classicrocker883 · classicrocker883 · commit af16dfe9e9be · 2025-10-15T22:54:11.000-04:00
diff --git a/.codacy/.codacy.yaml b/.codacy/.codacy.yaml
diff --git a/Marlin/_Bootscreen.h b/Marlin/_Bootscreen.h
@@ -19,7 +19,8 @@
 #define CUSTOM_BOOTSCREEN_BMPHEIGHT  64
 
 #if !defined(CUSTOM_BOOTSCREEN_ANIMATED)
-//*/ if machine is Voxelab Aquila add ( / ) to first in line and remove ( / ) from next block
+// Aquila block
+//*/ if machine is Voxelab Aquila add ( / ) to start of line and remove ( / ) from start of next block
 const unsigned char custom_start_bmp[] PROGMEM = {
   #if !CUSTOM_BOOTSCREEN_ALTERNATE
   B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,
@@ -119,8 +120,11 @@ const unsigned char custom_start_bmp[] PROGMEM = {
   #endif
 };
 //*/
+
 // ----------------------------------------------------------------
-/*/ if machine is Ender add ( / ) to first in line and remove ( / ) from previous block
+
+// Ender block
+/*/ if machine is Ender add ( / ) to start of line and remove ( / ) from start of previous block
 const unsigned char custom_start_bmp[] PROGMEM = {
   0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
   0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
diff --git a/buildroot/share/PlatformIO/scripts/SAMD21_minitronics20.py b/buildroot/share/PlatformIO/scripts/SAMD21_minitronics20.py
@@ -10,10 +10,10 @@
     env = pioutil.env
 
     mf = env["MARLIN_FEATURES"]
-    rx_Buf = mf["RX_BUFFER_SIZE"] if "RX_BUFFER_SIZE" in mf else "0"
-    tx_Buf = mf["TX_BUFFER_SIZE"] if "TX_BUFFER_SIZE" in mf else "0"
+    RXBUF = mf["RX_BUFFER_SIZE"] if "RX_BUFFER_SIZE" in mf else "0"
+    TXBUF = mf["TX_BUFFER_SIZE"] if "TX_BUFFER_SIZE" in mf else "0"
 
-    serialBuf = str(max(int(rx_Buf), int(tx_Buf), 350))
+    serialBuf = str(max(int(RXBUF), int(TXBUF), 350))
 
     build_flags = env.get("BUILD_FLAGS")
     env.Replace(BUILD_FLAGS=build_flags)
diff --git a/buildroot/share/PlatformIO/scripts/SAMD51_grandcentral_m4.py b/buildroot/share/PlatformIO/scripts/SAMD51_grandcentral_m4.py
@@ -10,10 +10,10 @@
     env = pioutil.env
 
     mf = env["MARLIN_FEATURES"]
-    rx_Buf = mf["RX_BUFFER_SIZE"] if "RX_BUFFER_SIZE" in mf else "0"
-    tx_Buf = mf["TX_BUFFER_SIZE"] if "TX_BUFFER_SIZE" in mf else "0"
+    RXBUF = mf["RX_BUFFER_SIZE"] if "RX_BUFFER_SIZE" in mf else "0"
+    TXBUF = mf["TX_BUFFER_SIZE"] if "TX_BUFFER_SIZE" in mf else "0"
 
-    serialBuf = str(max(int(rx_Buf), int(tx_Buf), 350))
+    serialBuf = str(max(int(RXBUF), int(TXBUF), 350))
 
     build_flags = env.get("BUILD_FLAGS")
     build_flags.append("-DSERIAL_BUFFER_SIZE=" + serialBuf)
diff --git a/buildroot/share/PlatformIO/scripts/stm32_serialbuffer.py b/buildroot/share/PlatformIO/scripts/stm32_serialbuffer.py
@@ -53,11 +53,11 @@ def tryAddFlag(name, value):
     mf = env["MARLIN_FEATURES"]
 
     # Get the largest defined buffer sizes for RX or TX, using defaults for undefined
-    rx_Buf = getBufferSize("RX", 128)
-    tx_Buf = getBufferSize("TX",  64)
+    RXBUF = getBufferSize("RX", 128)
+    TXBUF = getBufferSize("TX",  64)
 
     # Provide serial buffer sizes to the stm32duino platform
-    tryAddFlag("SERIAL_RX_BUFFER_SIZE", rx_Buf)
-    tryAddFlag("SERIAL_TX_BUFFER_SIZE", tx_Buf)
-    tryAddFlag("USART_RX_BUF_SIZE", rx_Buf)
-    tryAddFlag("USART_TX_BUF_SIZE", tx_Buf)
+    tryAddFlag("SERIAL_RX_BUFFER_SIZE", RXBUF)
+    tryAddFlag("SERIAL_TX_BUFFER_SIZE", TXBUF)
+    tryAddFlag("USART_RX_BUF_SIZE", RXBUF)
+    tryAddFlag("USART_TX_BUF_SIZE", TXBUF)
diff --git a/buildroot/share/dwin/bin/DWIN_ICO.py b/buildroot/share/dwin/bin/DWIN_ICO.py
@@ -78,7 +78,7 @@ def splitFile(self, filename, outDir):
     def _parseHeader(self, infile):
         maxEntries = 256
         count = 0
-        #icon_nums = _iconNames.keys()
+        #icon_nums = _icon_names.keys()
         while count < maxEntries:
             rawBytes = infile.read(16)
             entry = Entry()
@@ -105,7 +105,7 @@ def _splitEntryData(self, infile, outDir):
             if entry.length == 0:
                 count += 1
                 continue
-            outfilename = os.path.join(outDir, "%03d-ICON_%s.jpg" % (count, _iconNames.get(count, "UNKNOWN")))
+            outfilename = os.path.join(outDir, "%03d-ICON_%s.jpg" % (count, _icon_names.get(count, "UNKNOWN")))
             with open(outfilename, "wb") as outfile:
                 infile.seek(entry.offset)
                 blob = infile.read(entry.length)
@@ -254,113 +254,113 @@ def serialize(self):
                               0, 0, 0, 0, 0)
         return rawdata
 
-_iconNames = {
-     0: "LOGO_Creality",
-     1: "Print_0",
-     2: "Print_1",
-     3: "Prepare_0",
-     4: "Prepare_1",
-     5: "Control_0",
-     6: "Control_1",
-     7: "Leveling_0",
-     8: "Leveling_1",
-     9: "HotendTemp",
-    10: "BedTemp",
-    11: "Speed",
-    12: "Zoffset",
-    13: "Back",
-    14: "File",
-    15: "PrintTime",
-    16: "RemainTime",
-    17: "Setup_0",
-    18: "Setup_1",
-    19: "Pause_0",
-    20: "Pause_1",
-    21: "Continue_0",
-    22: "Continue_1",
-    23: "Stop_0",
-    24: "Stop_1",
-    25: "Bar",
-    26: "More",
-    27: "Axis",
-    28: "CloseMotor",
-    29: "Homing",
-    30: "SetHome",
-    31: "PLAPreheat",
-    32: "ABSPreheat",
-    33: "Cool",
-    34: "Language",
-    35: "MoveX",
-    36: "MoveY",
-    37: "MoveZ",
-    38: "Extruder",
-    # Skip 39
-    40: "Temperature",
-    41: "Motion",
-    42: "WriteEEPROM",
-    43: "ReadEEPROM",
-    44: "ResetEEPROM",
-    45: "Info",
-    46: "SetEndTemp",
-    47: "SetBedTemp",
-    48: "FanSpeed",
-    49: "SetPLAPreheat",
-    50: "SetABSPreheat",
-    51: "MaxSpeed",
-    52: "MaxAccelerated",
-    53: "MaxJerk",
-    54: "Step",
-    55: "PrintSize",
-    56: "Version",
-    57: "Contact",
-    58: "StockConfiguraton",
-    59: "MaxSpeedX",
-    60: "MaxSpeedY",
-    61: "MaxSpeedZ",
-    62: "MaxSpeedE",
-    63: "MaxAccX",
-    64: "MaxAccY",
-    65: "MaxAccZ",
-    66: "MaxAccE",
-    67: "MaxSpeedJerkX",
-    68: "MaxSpeedJerkY",
-    69: "MaxSpeedJerkZ",
-    70: "MaxSpeedJerkE",
-    71: "StepX",
-    72: "StepY",
-    73: "StepZ",
-    74: "StepE",
-    75: "Setspeed",
-    76: "SetZOffset",
-    77: "Rectangle",
-    78: "BLTouch",
-    79: "TempTooLow",
-    80: "AutoLeveling",
-    81: "TempTooHigh",
-    82: "NoTips_C",
-    83: "NoTips_E",
-    84: "Continue_C",
-    85: "Continue_E",
-    86: "Cancel_C",
-    87: "Cancel_E",
-    88: "Confirm_C",
-    89: "Confirm_E",
-    90: "Info_0",
-    91: "Info_1",
-    #92: "DegreesC",
-    93: "Printer_0",
-    #94: "Printer_1",
-   200: "Checkbox_F",
-   201: "Checkbox_T",
-   202: "Fade",
-   203: "Mesh",
-   204: "Tilt",
-   205: "Brightness",
-   206: "Probe",
-   249: "AxisD",
-   250: "AxisBR",
-   251: "AxisTR",
-   252: "AxisBL",
-   253: "AxisTL",
-   254: "AxisC"
+_icon_names = {
+      0: "LOGO_Creality",
+      1: "Print_0",
+      2: "Print_1",
+      3: "Prepare_0",
+      4: "Prepare_1",
+      5: "Control_0",
+      6: "Control_1",
+      7: "Leveling_0",
+      8: "Leveling_1",
+      9: "HotendTemp",
+     10: "BedTemp",
+     11: "Speed",
+     12: "Zoffset",
+     13: "Back",
+     14: "File",
+     15: "PrintTime",
+     16: "RemainTime",
+     17: "Setup_0",
+     18: "Setup_1",
+     19: "Pause_0",
+     20: "Pause_1",
+     21: "Continue_0",
+     22: "Continue_1",
+     23: "Stop_0",
+     24: "Stop_1",
+     25: "Bar",
+     26: "More",
+     27: "Axis",
+     28: "CloseMotor",
+     29: "Homing",
+     30: "SetHome",
+     31: "PLAPreheat",
+     32: "ABSPreheat",
+     33: "Cool",
+     34: "Language",
+     35: "MoveX",
+     36: "MoveY",
+     37: "MoveZ",
+     38: "Extruder",
+     # Skip 39
+     40: "Temperature",
+     41: "Motion",
+     42: "WriteEEPROM",
+     43: "ReadEEPROM",
+     44: "ResetEEPROM",
+     45: "Info",
+     46: "SetEndTemp",
+     47: "SetBedTemp",
+     48: "FanSpeed",
+     49: "SetPLAPreheat",
+     50: "SetABSPreheat",
+     51: "MaxSpeed",
+     52: "MaxAccelerated",
+     53: "MaxJerk",
+     54: "Step",
+     55: "PrintSize",
+     56: "Version",
+     57: "Contact",
+     58: "StockConfiguraton",
+     59: "MaxSpeedX",
+     60: "MaxSpeedY",
+     61: "MaxSpeedZ",
+     62: "MaxSpeedE",
+     63: "MaxAccX",
+     64: "MaxAccY",
+     65: "MaxAccZ",
+     66: "MaxAccE",
+     67: "MaxSpeedJerkX",
+     68: "MaxSpeedJerkY",
+     69: "MaxSpeedJerkZ",
+     70: "MaxSpeedJerkE",
+     71: "StepX",
+     72: "StepY",
+     73: "StepZ",
+     74: "StepE",
+     75: "Setspeed",
+     76: "SetZOffset",
+     77: "Rectangle",
+     78: "BLTouch",
+     79: "TempTooLow",
+     80: "AutoLeveling",
+     81: "TempTooHigh",
+     82: "NoTips_C",
+     83: "NoTips_E",
+     84: "Continue_C",
+     85: "Continue_E",
+     86: "Cancel_C",
+     87: "Cancel_E",
+     88: "Confirm_C",
+     89: "Confirm_E",
+     90: "Info_0",
+     91: "Info_1",
+     #92: "DegreesC",
+     93: "Printer_0",
+     #94: "Printer_1",
+    200: "Checkbox_F",
+    201: "Checkbox_T",
+    202: "Fade",
+    203: "Mesh",
+    204: "Tilt",
+    205: "Brightness",
+    206: "Probe",
+    249: "AxisD",
+    250: "AxisBR",
+    251: "AxisTR",
+    252: "AxisBL",
+    253: "AxisTL",
+    254: "AxisC"
 }
diff --git a/buildroot/share/scripts/MarlinBinaryProtocol.py b/buildroot/share/scripts/MarlinBinaryProtocol.py
@@ -438,18 +438,38 @@ def copy(self, filename, dest_filename, compression, dummy):
             self.write(data[start:end])
             kibs = (((i + 1) * block_size) / 1024) / (millis() + 1 - start_time) * 1000
             if (i / blocks) >= dump_pctg:
-                print("\r{0:2.0f}% {1:4.2f}KiB/s {2} Errors: {3}".format((i / blocks) * 100, kibs, "[{0:4.2f}KiB/s]".format(kibs * cratio) if compression else "", self.protocol.errors), end="")
+                print(
+                    "\r{0:2.0f}% {1:4.2f}KiB/s {2} Errors: {3}".format(
+                        (i / blocks) * 100, kibs,
+                        "[{0:4.2f}KiB/s]".format(kibs * cratio) if compression else "",
+                        self.protocol.errors
+                    ),
+                    end=""
+                )
                 dump_pctg += 0.1
             if self.protocol.errors > 0:
                 # Dump last status (errors may not be visible)
-                print("\r{0:2.0f}% {1:4.2f}KiB/s {2} Errors: {3} - Aborting...".format((i / blocks) * 100, kibs, "[{0:4.2f}KiB/s]".format(kibs * cratio) if compression else "", self.protocol.errors), end="")
+                print(
+                    "\r{0:2.0f}% {1:4.2f}KiB/s {2} Errors: {3} - Aborting...".format(
+                        (i / blocks) * 100, kibs,
+                        "[{0:4.2f}KiB/s]".format(kibs * cratio) if compression else "",
+                        self.protocol.errors
+                    ),
+                    end=""
+                )
                 print("")  # New line to break the transfer speed line
                 self.close()
                 print("Transfer aborted due to protocol errors")
                 #raise Exception("Transfer aborted due to protocol errors")
                 return False
-        print("\r{0:2.0f}% {1:4.2f}KiB/s {2} Errors: {3}".format(100, kibs, "[{0:4.2f}KiB/s]".format(kibs * cratio) if compression else "", self.protocol.errors))  # No one likes transfers finishing at 99.8%
-
+        # No one likes transfers finishing at 99.8%
+        print(
+            "\r{0:2.0f}% {1:4.2f}KiB/s {2} Errors: {3}".format(
+                100, kibs,
+                "[{0:4.2f}KiB/s]".format(kibs * cratio) if compression else "",
+                self.protocol.errors
+            )
+        )
         if not self.close():
             print("Transfer failed")
             return False
diff --git a/configurations/Voxelab Aquila HC32/C2/Default/_Bootscreen.h b/configurations/Voxelab Aquila HC32/C2/Default/_Bootscreen.h
@@ -19,7 +19,8 @@
 #define CUSTOM_BOOTSCREEN_BMPHEIGHT  64
 
 #if !defined(CUSTOM_BOOTSCREEN_ANIMATED)
-//*/ if machine is Voxelab Aquila add ( / ) to first in line and remove ( / ) from next block
+// Aquila block
+//*/ if machine is Voxelab Aquila add ( / ) to start of line and remove ( / ) from start of next block
 const unsigned char custom_start_bmp[] PROGMEM = {
   #if !CUSTOM_BOOTSCREEN_ALTERNATE
   B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,
@@ -119,8 +120,11 @@ const unsigned char custom_start_bmp[] PROGMEM = {
   #endif
 };
 //*/
+
 // ----------------------------------------------------------------
-/*/ if machine is Ender add ( / ) to first in line and remove ( / ) from previous block
+
+// Ender block
+/*/ if machine is Ender add ( / ) to start of line and remove ( / ) from start of previous block
 const unsigned char custom_start_bmp[] PROGMEM = {
   0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
   0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
diff --git a/configurations/Voxelab Aquila HC32/C2/MM/_Bootscreen.h b/configurations/Voxelab Aquila HC32/C2/MM/_Bootscreen.h
@@ -19,7 +19,8 @@
 #define CUSTOM_BOOTSCREEN_BMPHEIGHT  64
 
 #if !defined(CUSTOM_BOOTSCREEN_ANIMATED)
-//*/ if machine is Voxelab Aquila add ( / ) to first in line and remove ( / ) from next block
+// Aquila block
+//*/ if machine is Voxelab Aquila add ( / ) to start of line and remove ( / ) from start of next block
 const unsigned char custom_start_bmp[] PROGMEM = {
   #if !CUSTOM_BOOTSCREEN_ALTERNATE
   B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,B00000000,
@@ -119,8 +120,11 @@ const unsigned char custom_start_bmp[] PROGMEM = {
   #endif
 };
 //*/
+
 // ----------------------------------------------------------------
-/*/ if machine is Ender add ( / ) to first in line and remove ( / ) from previous block
+
+// Ender block
+/*/ if machine is Ender add ( / ) to start of line and remove ( / ) from start of previous block
 const unsigned char custom_start_bmp[] PROGMEM = {
   0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
   0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
diff --git a/display assets/Aquila Display Firmware/Icon Tools/Scripts/DWIN_ICO.py b/display assets/Aquila Display Firmware/Icon Tools/Scripts/DWIN_ICO.py
diff --git a/slicer scripts/cura/CreateJPEGThumbnail.py b/slicer scripts/cura/CreateJPEGThumbnail.py
