🩹 Fix and clean up some stuff (#28201)

Author: classicrocker883

Marlin/src/core/types.h

@@ -816,9 +816,9 @@ struct XYZval {
   FI XYZval<T>& operator-=(const XYZEval<T> &rs) { NUM_AXIS_CODE(x -= rs.x, y -= rs.y, z -= rs.z, i -= rs.i, j -= rs.j, k -= rs.k, u -= rs.u, v -= rs.v, w -= rs.w); return *this; }
   FI XYZval<T>& operator*=(const XYZEval<T> &rs) { NUM_AXIS_CODE(x *= rs.x, y *= rs.y, z *= rs.z, i *= rs.i, j *= rs.j, k *= rs.k, u *= rs.u, v *= rs.v, w *= rs.w); return *this; }
   FI XYZval<T>& operator/=(const XYZEval<T> &rs) { NUM_AXIS_CODE(x /= rs.x, y /= rs.y, z /= rs.z, i /= rs.i, j /= rs.j, k /= rs.k, u /= rs.u, v /= rs.v, w /= rs.w); return *this; }
-  FI XYZval<T>& operator*=(const float p)        { NUM_AXIS_CODE(x *= p, y *= p, z *= p, i *= p, j *= p, k *= p, u *= p, v *= p, w *= p); return *this; }
+  FI XYZval<T>& operator*=(const float &p)       { NUM_AXIS_CODE(x *= p, y *= p, z *= p, i *= p, j *= p, k *= p, u *= p, v *= p, w *= p); return *this; }
   FI XYZval<T>& operator*=(const int &p)         { NUM_AXIS_CODE(x *= p, y *= p, z *= p, i *= p, j *= p, k *= p, u *= p, v *= p, w *= p); return *this; }
-  FI XYZval<T>& operator/=(const float p)        { NUM_AXIS_CODE(x /= p, y /= p, z /= p, i /= p, j /= p, k /= p, u /= p, v /= p, w /= p); return *this; }
+  FI XYZval<T>& operator/=(const float &p)       { NUM_AXIS_CODE(x /= p, y /= p, z /= p, i /= p, j /= p, k /= p, u /= p, v /= p, w /= p); return *this; }
   FI XYZval<T>& operator>>=(const int &p)        { NUM_AXIS_CODE(_RSE(x), _RSE(y), _RSE(z), _RSE(i), _RSE(j), _RSE(k), _RSE(u), _RSE(v), _RSE(w)); return *this; }
   FI XYZval<T>& operator<<=(const int &p)        { NUM_AXIS_CODE(_LSE(x), _LSE(y), _LSE(z), _LSE(i), _LSE(j), _LSE(k), _LSE(u), _LSE(v), _LSE(w)); return *this; }
 

Marlin/src/feature/powerloss.h

@@ -201,9 +201,11 @@ class PrintJobRecovery {
     static void close() { file.close(); }
 
     static bool check();
+
     #if ENABLED(PLR_HEAT_BED_ON_REBOOT)
       static void set_bed_temp(const bool turn_on);
     #endif
+
     static void resume();
     static void purge();
 

Marlin/src/module/endstops.cpp

@@ -984,23 +984,23 @@ void Endstops::update() {
   void Endstops::clear_endstop_state() {
 
     #define _ES_CLEAR(S) CBI(live_state, S##_ENDSTOP);
-    #define ES_CLEAR(S) TERN_(S##_SPI_SENSORLESS, CBI(live_state, S##_ENDSTOP));
+    #define ES_CLEAR(S) TERN_(S##_SPI_SENSORLESS, _ES_CLEAR(S));
 
     ES_CLEAR(X);
     #if ALL(X_SPI_SENSORLESS, X_DUAL_ENDSTOPS)
-      CBI(live_state, X2_ENDSTOP);
+      _ES_CLEAR(X2);
     #endif
     ES_CLEAR(Y);
     #if ALL(Y_SPI_SENSORLESS, Y_DUAL_ENDSTOPS)
-      CBI(live_state, Y2_ENDSTOP);
+      _ES_CLEAR(Y2);
     #endif
     ES_CLEAR(Z);
     #if ALL(Z_SPI_SENSORLESS, Z_MULTI_ENDSTOPS)
-      CBI(live_state, Z2_ENDSTOP);
+      _ES_CLEAR(Z2);
       #if NUM_Z_STEPPERS >= 3
-        CBI(live_state, Z3_ENDSTOP);
+        _ES_CLEAR(Z3);
         #if NUM_Z_STEPPERS >= 4
-          CBI(live_state, Z4_ENDSTOP);
+          _ES_CLEAR(Z4);
         #endif
       #endif
     #endif
@@ -1040,9 +1040,9 @@ void Endstops::update() {
     #define ES_REPORT_CHANGE(S)  TERF(USE_##S, _ES_REPORT_CHANGE)(S)
 
     if (endstop_change) {
-      MAP(ES_REPORT_CHANGE, X_MIN, X_MAX, Y_MIN, Y_MAX, Z_MIN, Z_MAX,
-                          , Z_MIN_PROBE, CALIBRATION,
-                          , X2_MIN, X2_MAX, Y2_MIN, Y2_MAX, Z2_MIN, Z2_MAX, Z3_MIN, Z3_MAX, Z4_MIN, Z4_MAX,
+      MAP(ES_REPORT_CHANGE, X_MIN, X_MAX, Y_MIN, Y_MAX, Z_MIN, Z_MAX
+                          , Z_MIN_PROBE, CALIBRATION
+                          , X2_MIN, X2_MAX, Y2_MIN, Y2_MAX, Z2_MIN, Z2_MAX, Z3_MIN, Z3_MAX, Z4_MIN, Z4_MAX
                           , I_MIN, I_MAX, J_MIN, J_MAX, K_MIN, K_MAX, U_MIN, U_MAX, V_MIN, V_MAX, W_MIN, W_MAX);
       SERIAL_ECHOLNPGM("\n");
       hal.set_pwm_duty(pin_t(LED_PIN), local_LED_status);

Marlin/src/module/stepper/indirection.h

@@ -577,6 +577,7 @@ void reset_stepper_drivers();    // Called by settings.load / settings.reset
  * Extruder indirection for the single E axis
  */
 #if HAS_SWITCHING_EXTRUDER // One stepper driver per two extruders, reversed on odd index
+
   #if EXTRUDERS > 7
     #define E_STEP_WRITE(E,V) do{ if (E < 2) { E0_STEP_WRITE(V); } else if (E < 4) { E1_STEP_WRITE(V); } else if (E < 6) { E2_STEP_WRITE(V); } else { E3_STEP_WRITE(V); } }while(0)
     #define    FWD_E_DIR(E)   do{ switch (E) { \
@@ -758,15 +759,16 @@ void reset_stepper_drivers();    // Called by settings.load / settings.reset
 
   #elif E_STEPPERS > 2
 
-    #define _E_STEP_WRITE(E,V) do{ switch (E) { case 0: E0_STEP_WRITE(V); break; case 1: E1_STEP_WRITE(V); break; case 2: E2_STEP_WRITE(V); } }while(0)
-    #define    _FWD_E_DIR(E)   do{ switch (E) { case 0: E0_DIR_WRITE(HIGH); break; case 1: E1_DIR_WRITE(HIGH); break; case 2: E2_DIR_WRITE(HIGH); } }while(0)
-    #define    _REV_E_DIR(E)   do{ switch (E) { case 0: E0_DIR_WRITE(LOW ); break; case 1: E1_DIR_WRITE(LOW ); break; case 2: E2_DIR_WRITE(LOW ); } }while(0)
+    #define _E_STEP_WRITE(E,V) do{ switch (E) { case 0: E0_STEP_WRITE(V); break; case 1: E1_STEP_WRITE(V); break; case 2: E2_STEP_WRITE(V); break; } }while(0)
+    #define    _FWD_E_DIR(E)   do{ switch (E) { case 0: E0_DIR_WRITE(HIGH); break; case 1: E1_DIR_WRITE(HIGH); break; case 2: E2_DIR_WRITE(HIGH); break; } }while(0)
+    #define    _REV_E_DIR(E)   do{ switch (E) { case 0: E0_DIR_WRITE(LOW ); break; case 1: E1_DIR_WRITE(LOW ); break; case 2: E2_DIR_WRITE(LOW ); break; } }while(0)
 
   #else
 
     #define _E_STEP_WRITE(E,V) do{ if (E == 0) { E0_STEP_WRITE(V); } else { E1_STEP_WRITE(V); } }while(0)
     #define    _FWD_E_DIR(E)   do{ if (E == 0) { E0_DIR_WRITE(HIGH); } else { E1_DIR_WRITE(HIGH); } }while(0)
     #define    _REV_E_DIR(E)   do{ if (E == 0) { E0_DIR_WRITE(LOW ); } else { E1_DIR_WRITE(LOW ); } }while(0)
+
   #endif
 
   #if HAS_DUPLICATION_MODE