save settings DEFAULT_EJERK

[yrabbit]

MRiscoCProUI/Marlin/src/module/settings.cpp

Line 944 in fef8476

dummyf = float(DEFAULT_EJERK);

Hi, a little problem with DEFAULT_EJERK - the thing is that it is defined just in case of ENABLED(CLASSIC_JERK), and otherwise it just doesn't exist and the above line gives a compilation error.

MRiscoCProUI/configurations/Voxelab Aquila 427/UBL/Configuration.h

Lines 1367 to 1386 in fef8476

	#define CLASSIC_JERK
	#if ENABLED(CLASSIC_JERK)
	#define DEFAULT_XJERK 10.0
	#define DEFAULT_YJERK 10.0
	#define DEFAULT_ZJERK 0.4
	#define DEFAULT_EJERK 10.0
	//#define DEFAULT_IJERK 0.3
	//#define DEFAULT_JJERK 0.3
	//#define DEFAULT_KJERK 0.3
	//#define DEFAULT_UJERK 0.3
	//#define DEFAULT_VJERK 0.3
	//#define DEFAULT_WJERK 0.3
	//#define TRAVEL_EXTRA_XYJERK 0.0 // Additional jerk allowance for all travel moves
	//#define LIMITED_JERK_EDITING // Limit edit via M205 or LCD to DEFAULT_aJERK * 2
	#if ENABLED(LIMITED_JERK_EDITING)
	#define MAX_JERK_EDIT_VALUES { 20, 20, 1, 20 } // ...or, set your own edit limits
	#endif
	#endif

[classicrocker883]

Sorry I dont understand what the issue is.

• Can you explain it a bit better and what compilation error?
• What does settings.cpp have to do with this?
• Can you show me your configuration files and how you came to this conclusion?

Just for instance, the menu gets its max/min values from limits.h.

MRiscoCProUI/Marlin/src/lcd/e3v2/common/limits.h

Lines 72 to 97 in fef8476

	//
	// Max Jerk limits
	//
	#if ENABLED(CLASSIC_JERK)
	#define MIN_JERK_EDIT_VALUE 0.1
	constexpr xyze_float_t min_jerk_edit_values = LOGICAL_AXIS_ARRAY_1(MIN_JERK_EDIT_VALUE);
	#if !defined(MAX_JERK_EDIT_VALUES) && defined(DEFAULT_MAX_MULTIPLIER)
	#define DEFAULT_MAX_JERK_MULTIPLIER 2
	constexpr xyze_float_t default_jerk = LOGICAL_AXIS_ARRAY(
	DEFAULT_EJERK,
	DEFAULT_XJERK, DEFAULT_YJERK, DEFAULT_ZJERK,
	DEFAULT_IJERK, DEFAULT_JJERK, DEFAULT_KJERK,
	DEFAULT_UJERK, DEFAULT_VJERK, DEFAULT_WJERK
	);
	#endif
	constexpr xyze_float_t max_jerk_edit_values =
	#ifdef MAX_JERK_EDIT_VALUES
	MAX_JERK_EDIT_VALUES
	#elif defined(DEFAULT_MAX_MULTIPLIER)
	default_jerk * DEFAULT_MAX_JERK_MULTIPLIER
	#else
	{ DEFAULT_XJERK * 2, DEFAULT_YJERK * 2, DEFAULT_ZJERK * 4, DEFAULT_EJERK * 4 }
	#endif
	;
	#endif

---

basically it comes down to these values

  constexpr xyze_float_t min_jerk_edit_values = LOGICAL_AXIS_ARRAY_1(MIN_JERK_EDIT_VALUE); // { 0.1, 0.1, 0.1, 0.1 }
  constexpr xyze_float_t max_jerk_edit_values = { DEFAULT_XJERK * 2, DEFAULT_YJERK * 2, DEFAULT_ZJERK * 4, DEFAULT_EJERK * 4 };

[yrabbit]

I wasn't actually guessing, I'm just getting my printer up to date with the current version for the first time since October and the compilation has failed somewhat.

Then I just put the value 10. instead of the name (well since it's ‘dummy’ there anyway) and I have to report that the February version works fine :)

I just wanted to let you know about this problem.

Here are the configuration files, but honestly I don't think there's anything criminal there - they're the same as they were in October when we last chatted.

[classicrocker883]

ah i see. I have made changes in that file since then and notice a couple odd things.
basically there is an impossibility for HAS_LINEAR_E_JERK while CLASSIC_JERK is disabled (i.e. Junction Deviation).

so I assume that is what you are using then, JD - HAS_JUNCTION_DEVIATION?

I can come up with a better fix, but for now just use the Marlin original code I guess for now. it isnt just this line but there are a couple lines like this I made changes to.

// Original Marlin code

      #if ENABLED(CLASSIC_JERK)
        EEPROM_WRITE(planner.max_jerk);
        #if HAS_LINEAR_E_JERK
          dummyf = float(DEFAULT_EJERK);
          EEPROM_WRITE(dummyf);
        #endif
      #else
        const xyze_pos_t planner_max_jerk = LOGICAL_AXIS_ARRAY(5, 10, 10, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4);
        EEPROM_WRITE(planner_max_jerk);
      #endif


// My changed code line ~938
      #if ENABLED(CLASSIC_JERK)
        EEPROM_WRITE(planner.max_jerk);
      #else
        const xyze_pos_t planner_max_jerk = LOGICAL_AXIS_ARRAY(10, 10, 10, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4);
        EEPROM_WRITE(planner_max_jerk);
        #if HAS_LINEAR_E_JERK
          dummyf = float(DEFAULT_EJERK);
          EEPROM_WRITE(dummyf);
        #endif
      #endif

// Marlin Original code

        #if ENABLED(CLASSIC_JERK)
          EEPROM_READ(planner.max_jerk);
          #if HAS_LINEAR_E_JERK
            EEPROM_READ(dummyf);
          #endif
        #else
          for (uint8_t q = LOGICAL_AXES; q--;) EEPROM_READ(dummyf);
        #endif


// My changed code line ~2100

        #if ENABLED(CLASSIC_JERK)
          EEPROM_READ(planner.max_jerk);
        #else
          for (uint8_t q = LOGICAL_AXES; q--;) EEPROM_READ(dummyf);
          #if HAS_LINEAR_E_JERK
            EEPROM_READ(dummyf);
          #endif
        #endif

[yrabbit]

so I assume that is what you are using then, JD - HAS_JUNCTION_DEVIATION?

Yeah, that's right.

Of course it will be a pity if MarlinFirmware/Marlin#27710 is not compatible with JD, but we'll see that later :)

[classicrocker883]

Im pretty sure that itis compatible, I just never used it. there are menu options for JD so if you end up enabling - im curious how it differs from classic jerk - for better or worse?

[classicrocker883]

just try deleting

        #if HAS_LINEAR_E_JERK
          dummyf = float(DEFAULT_EJERK);
          EEPROM_WRITE(dummyf);
        #endif

in settings.cpp from line 943-946,
let. me know if this works out well for you

[yrabbit]

Im pretty sure that itis compatible, I just never used it. there are menu options for JD so if you end up enabling - im curious how it differs from classic jerk - for better or worse?

Printers, especially our printers, are different mechanically, so for me JD gives the best results. If you're interested in the theory behind it, a little video:

https://www.youtube.com/watch?v=Mnvj6xCzikM?t=715

Well JD has indeed been the default in the original repository for a long time 😉 https://github.com/MarlinFirmware/Marlin/blob/efba06c4ce4253a42318da62dc696e8d64e21206/Marlin/Configuration.h#L1345-L1350

[classicrocker883]

nice. thanks for the info. btw. I updated the code so it would stop that error (default branch has those changes), I couldn't figure out another workaround so I hope just omitting it makes it work out.

if you could let me know it still works or if theres an issue id appreciate it (hoping I did the right thing regarding settings.cpp) because that file is touchy as hell. a small change can make bigger problems.

[yrabbit]

Yes, at commit 4d7f7e6 compiles and prints without any issues 👍

[yrabbit]

Okay, I jumped to conclusions. Every time I switch on (without SDcard inserted) it says ‘Default settings restored’.

This is not a problem for me since my settings are default since I set them directly in the source code, but I can imagine it is inconvenient for those who expect the settings to be saved between powerups.

I wonder what condition is the trigger for ‘Default settings restored’? Some kind of checksum?

VID_20250226_102733.mp4

[classicrocker883]

yes I have noticed that too. same with having "Mesh # Loaded" at startup, if you look at fef8476 , it was successful in stopping that message from loading, however for some reason it would not save settings after changing them. so that is why it was reverted.

anyway, all that it is saying is EEPROM is initialized.
if you look at Marlin\src\module\settings.cpp - line 3328
MSG_EEPROM_INITIALIZED = "Default Settings Restored"

  bool MarlinSettings::load() {
    // If the EEPROM data is valid load it
    if (validate()) {
      const EEPROM_Error err = _load();
      const bool success = (err == ERR_EEPROM_NOERR);
      TERN_(EXTENSIBLE_UI, ExtUI::onSettingsLoaded(success));
      return success;
    }

    // Otherwise reset settings to default "factory settings"
    reset();

    // Options to overwrite the EEPROM on error
    #if ANY(EEPROM_AUTO_INIT, EEPROM_INIT_NOW)
      (void)init_eeprom();
      LCD_MESSAGE(MSG_EEPROM_INITIALIZED);
      SERIAL_ECHO_MSG(STR_EEPROM_INITIALIZED);
    #endif

    return false;
  }

EEPROM_AUTO_INIT / EEPROM_INIT_NOW are kind of optional, I just never bothered disabling.

so I totally get what you're thinking, instead of saying "Default Settings Restored" at startup, it should say what is actually happening... "EEPROM Initialized"

---

going back to the DEFAULT_EJERK from before, I even put in a BUG issue at Marlin.
too bad nothing has been done and its now locked: MarlinFirmware/Marlin#27418

[yrabbit]

so I totally get what you're thinking, instead of saying "Default Settings Restored" at startup, it should say what is actually happening... "EEPROM Initialized"

To be honest, I meant that the M501 should not swear at the EEPROM and I was wondering what kind of event serves as a flag for it - size mismatch, checksum mismatch or something else.

If your M501 passes normally, then probably my EEPROM is just dead.