Partial bugfix 86 - modify experiment preserves previous edits (#88)

* Return full state from form submit
* Return full state from permutation form submit as well
* Write test cases to trigger bug/check fix

Author: Peter9192

apps/class-solid/src/components/ExperimentConfigForm.tsx

@@ -42,7 +42,7 @@ export function ExperimentConfigForm({
       id={id}
       onSubmit={handleSubmit}
       shouldActive={false} // Also return from collapsed fields
-      shouldDirty={true} // Don't return empty strings for unset fields
+      shouldDirty={false} // ~Don't return empty strings for unset fields~
     >
       <div>
         <ObjectField

apps/class-solid/src/components/PermutationsList.tsx

@@ -79,7 +79,7 @@ function PermutationConfigForm(props: {
       id={props.id}
       onSubmit={handleSubmit}
       shouldActive={false} // Also return from collapsed fields
-      shouldDirty={true} // Don't return empty strings for unset fields
+      shouldDirty={false} // ~Don't return empty strings for unset fields~
     >
       <div>
         <ObjectField
@@ -222,7 +222,7 @@ function PermutationDifferenceButton(props: {
           </fieldset>
           <fieldset class="border">
             <legend>Permutation configuration</legend>
-            <pre>{prunedPermutation()}</pre>
+            <pre title="PermutationConfig">{prunedPermutation()}</pre>
           </fieldset>
         </div>
       </DialogContent>

apps/class-solid/tests/modify.spec.ts

@@ -0,0 +1,75 @@
+import { expect, test } from "@playwright/test";
+
+// Check that modifying an experiment preserves previous edits
+test("Edit experiment preserves previous edits", async ({ page }) => {
+  await page.goto("/");
+
+  // Create new experiment with custom ABL height
+  await page.getByRole("button", { name: "Add Start from scratch (" }).click();
+  await page.getByRole("button", { name: "Initial State Button" }).click();
+  await page.getByLabel("ABL height").fill("800");
+  await page.getByRole("button", { name: "Run" }).click();
+
+  // Edit a second field
+  await page.getByRole("button", { name: "Edit" }).click();
+  await page.getByRole("button", { name: "Time control Button" }).click();
+  await page.getByLabel("Time step").fill("30");
+  await page.getByRole("button", { name: "Run" }).click();
+
+  // Open editor again and check that both values are still updated
+  await page.getByRole("button", { name: "Edit" }).click();
+  await page.getByRole("button", { name: "Initial State Button" }).click();
+  await expect(page.getByLabel("ABL height")).toHaveValue("800");
+  await page.getByRole("button", { name: "Time control Button" }).click();
+  await expect(page.getByLabel("Time step")).toHaveValue("30");
+});
+
+test("Edit permutation preserves previous edits", async ({ page }) => {
+  // Add experiment
+  await page.goto("/");
+  await page.getByRole("button", { name: "Add Start from scratch (" }).click();
+  await page.getByRole("button", { name: "Run" }).click();
+
+  // Add permutation with very small initial temperature jump
+  // Expect boundary layer to grow very quickly
+  const experiment1 = page.getByLabel("My experiment 1", { exact: true });
+  await experiment1
+    .getByTitle(
+      "Add a permutation to the reference configuration of this experiment",
+    )
+    .click();
+  await page.getByRole("button", { name: "Initial State Button" }).click();
+  await page.getByLabel("Temperature jump at h").fill("0.1");
+  await page.getByRole("button", { name: "Run" }).click();
+  // TODO: this gives weird looking results, fix + add check; how to test??
+
+  // Modify permutation: perhaps time step is too large?
+  await page.getByRole("button", { name: "Edit permutation" }).click();
+  await page.getByRole("button", { name: "Time control Button" }).click();
+  await page.getByLabel("Time step").fill("0.1");
+  await page.getByRole("button", { name: "Run" }).click();
+  // TODO: this gives NaN values, fix and add check
+
+  // Set time step back to a more reasonable value
+  await page.getByRole("button", { name: "Edit permutation" }).click();
+  await page.getByRole("button", { name: "Time control Button" }).click();
+  await page.getByLabel("Time step").fill("1");
+  await page.getByRole("button", { name: "Run" }).click();
+
+  // Verify both initial jump and time step are still modified
+  await page
+    .getByRole("button", { name: "View differences between this" })
+    .click();
+  await expect(page.getByTitle("PermutationConfig")).toHaveText(
+    `
+    {
+      "initialState": {
+        "dtheta_0": 0.1
+      },
+      "timeControl": {
+        "dt": 1
+      }
+    }
+   `,
+  );
+});