tweak: extract node types into enum

Author: Clauderic Demers

src/SortableContainer/defaultShouldCancelStart.js

@@ -1,8 +1,16 @@
+import {NodeType} from '../utils';
+
 export default function defaultShouldCancelStart(event) {
   // Cancel sorting if the event target is an `input`, `textarea`, `select` or `option`
-  const disabledElements = ['input', 'textarea', 'select', 'option', 'button'];
+  const disabledElements = [
+    NodeType.Input,
+    NodeType.Textarea,
+    NodeType.Select,
+    NodeType.Option,
+    NodeType.Button,
+  ];
 
-  if (disabledElements.indexOf(event.target.tagName.toLowerCase()) !== -1) {
+  if (disabledElements.indexOf(event.target.tagName) !== -1) {
     // Return true to cancel sorting
     return true;
   }

src/SortableContainer/index.js

@@ -16,6 +16,7 @@ import {
   getPosition,
   isTouchEvent,
   limit,
+  NodeType,
   omit,
   provideDisplayName,
   setInlineStyles,
@@ -140,10 +141,7 @@ export default function sortableContainer(
          * prevent subsequent 'mousemove' events from being fired
          * (see https://github.com/clauderic/react-sortable-hoc/issues/118)
          */
-        if (
-          !isTouchEvent(event) &&
-          event.target.tagName.toLowerCase() === 'a'
-        ) {
+        if (!isTouchEvent(event) && event.target.tagName === NodeType.Anchor) {
           event.preventDefault();
         }
 

src/utils.js

@@ -239,3 +239,13 @@ export function getScrollingParent(el) {
     return getScrollingParent(el.parentNode);
   }
 }
+
+export const NodeType = {
+  Anchor: 'A',
+  Button: 'BUTTON',
+  Canvas: 'CANVAS',
+  Input: 'INPUT',
+  Option: 'OPTION',
+  Textarea: 'TEXTAREA',
+  Select: 'SELECT',
+};