Fix script analyzer rules

Author: claudiospizzi

.build.ps1

@@ -5,3 +5,6 @@
 # Build configuration
 $IBHConfig.GalleryTask.TokenCallback    = { Get-BuildSecret -EnvironmentVariable 'PS_GALLERY_KEY' -CredentialManager 'PowerShell Gallery Key (claudiospizzi)' }
 $IBHConfig.RepositoryTask.TokenCallback = { Get-BuildSecret -EnvironmentVariable 'GITHUB_TOKEN' -CredentialManager 'GitHub Token (claudiospizzi)' }
+
+# This rule generates too many false positives with parameter splatting and argument completers
+$IBHConfig.AnalyzerTestTask.ScriptAnalyzerRules = Get-ScriptAnalyzerRule | Where-Object { $_.RuleName -ne 'PSReviewUnusedParameter' }

AnsibleCtl/Functions/Start-AnsibleCtl.ps1

@@ -395,8 +395,6 @@ function Start-AnsibleCtl
 Register-ArgumentCompleter -CommandName 'Start-AnsibleCtl' -ParameterName 'AnsibleVersion' -ScriptBlock {
     param ($CommandName, $ParameterName, $WordToComplete, $CommandAst, $FakeBoundParameters)
 
-    $ciSuffix = '-ci'
-
     # Query the config.json from the GitHub repository to get the available
     # Ansible versions which will be builded and published to the container.
     # This is not perfect, but the image registry has non anonymous API to get
@@ -405,7 +403,7 @@ Register-ArgumentCompleter -CommandName 'Start-AnsibleCtl' -ParameterName 'Ansib
     foreach ($ansibleVersion in $config.ansible.versions) {
         if ($ansibleVersion -like "$WordToComplete*") {
             [System.Management.Automation.CompletionResult]::new($ansibleVersion, $ansibleVersion, 'ParameterValue', $ansibleVersion)
-            [System.Management.Automation.CompletionResult]::new("$ansibleVersion$ciSuffix", "$ansibleVersion$ciSuffix", 'ParameterValue', "$ansibleVersion$ciSuffix")
+            [System.Management.Automation.CompletionResult]::new("$ansibleVersion-ci", "$ansibleVersion-ci", 'ParameterValue', "$ansibleVersion-ci")
         }
     }
 }