Skip to content
This repository was archived by the owner on May 15, 2022. It is now read-only.

Commit 19cda3a

Browse files
Updated README removing yarn references and added CONTRIBUTING.md
1 parent c4194be commit 19cda3a

File tree

2 files changed

+85
-11
lines changed

2 files changed

+85
-11
lines changed

CONTRIBUTING.md

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
# Contributing
2+
3+
When contributing to this repository, please first discuss the change you wish to make via creating an issue before making a change.
4+
5+
Please note we have a code of conduct, please follow it in all your interactions with the project.
6+
7+
## Pull Request Process
8+
9+
1. This repository follows the [`git-flow`](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow) workflow
10+
2. After you have made your issue, please create a feature branch off `develop` on your fork and name it in a descriptive way for example `feature/describes-my-feature`
11+
3. After you have done this, please raise a PR to the `develop` branch, this will ensure that CI runs on your branch before it can be merged
12+
4. After your PR has been merged, the library maintainers will cut a release and your change will be made available in a patch, minor or major release shortly
13+
14+
## Code of Conduct
15+
16+
### Our Pledge
17+
18+
In the interest of fostering an open and welcoming environment, we as
19+
contributors and maintainers pledge to making participation in our project and
20+
our community a harassment-free experience for everyone, regardless of age, body
21+
size, disability, ethnicity, gender identity and expression, level of experience,
22+
nationality, personal appearance, race, religion, or sexual identity and
23+
orientation.
24+
25+
### Our Standards
26+
27+
Examples of behavior that contributes to creating a positive environment
28+
include:
29+
30+
* Using welcoming and inclusive language
31+
* Being respectful of differing viewpoints and experiences
32+
* Gracefully accepting constructive criticism
33+
* Focusing on what is best for the community
34+
* Showing empathy towards other community members
35+
36+
Examples of unacceptable behavior by participants include:
37+
38+
* The use of sexualized language or imagery and unwelcome sexual attention or
39+
advances
40+
* Trolling, insulting/derogatory comments, and personal or political attacks
41+
* Public or private harassment
42+
* Publishing others' private information, such as a physical or electronic
43+
address, without explicit permission
44+
* Other conduct which could reasonably be considered inappropriate in a
45+
professional setting
46+
47+
### Our Responsibilities
48+
49+
Project maintainers are responsible for clarifying the standards of acceptable
50+
behavior and are expected to take appropriate and fair corrective action in
51+
response to any instances of unacceptable behavior.
52+
53+
Project maintainers have the right and responsibility to remove, edit, or
54+
reject comments, commits, code, wiki edits, issues, and other contributions
55+
that are not aligned to this Code of Conduct, or to ban temporarily or
56+
permanently any contributor for other behaviors that they deem inappropriate,
57+
threatening, offensive, or harmful.
58+
59+
### Scope
60+
61+
This Code of Conduct applies both within project spaces and in public spaces
62+
when an individual is representing the project or its community. Examples of
63+
representing a project or community include using an official project e-mail
64+
address, posting via an official social media account, or acting as an appointed
65+
representative at an online or offline event. Representation of a project may be
66+
further defined and clarified by project maintainers.
67+
68+
### Attribution
69+
70+
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
71+
available at [http://contributor-covenant.org/version/1/4][version]
72+
73+
[homepage]: http://contributor-covenant.org
74+
[version]: http://contributor-covenant.org/version/1/4/

README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -218,31 +218,31 @@ git clone https://github.com/claus/react-dat-gui.git react-dat-gui
218218
cd react-dat-gui
219219
```
220220
221-
Setup symlinks and install dependencies
221+
In order to see your changes to `react-dat-gui` the best way is to develop on the package and the example simultaneously. To do this, follow these steps.
222+
223+
### 1. Setup symlinks and install dependencies
222224
223225
```bash
224-
yarn install
225-
yarn link
226+
npm install
226227
cd example
227-
yarn link react-dat-gui
228-
yarn install
228+
npm install
229229
```
230230
231-
Run the library in development mode
231+
### 2. Run the library in development mode
232232
233233
```bash
234234
cd ..
235-
yarn start
235+
npm run dev
236236
```
237237
238-
Run the example app in development mode
238+
### 3. Run the example app in development mode (in second terminal window)
239239
240240
```bash
241241
cd example
242-
yarn start
242+
npm run dev
243243
```
244244
245-
Changes to the library code should hot reload in the demo app
245+
After the example has compiled, it should be available for viewing at [http://localhost:3000](http://localhost:3000). Changes to the library code should now hot reload in the example app
246246
247247
## Scripts
248248
@@ -272,7 +272,7 @@ Local storage however is in the roadmap and will probably be done very soon.
272272
- Loading and storing both default and preset data via `localStorage`
273273
- Animations for `DatFolder` expanding/collapsing
274274
- Time travel with undo/redo buttons
275-
- Better support for floating point `DatNumber`s (rounding etc.)
275+
- ~~Better support for floating point `DatNumber`s (rounding etc.)~~
276276

277277
## License
278278

0 commit comments

Comments
 (0)