Skip to content
This repository was archived by the owner on May 15, 2022. It is now read-only.

Commit 1d2f6e4

Browse files
Ensured that DatNumber values will always be numbers, not strings
1 parent d004a8e commit 1d2f6e4

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

build/react-dat-gui.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6880,8 +6880,8 @@ var DatNumber = function (_Component) {
68806880
var value = this.state.value;
68816881

68826882

6883-
this.props._onUpdateValue && this.props._onUpdateValue(this.props.path, value);
6884-
this.props.onUpdate && this.props.onUpdate(value);
6883+
this.props._onUpdateValue && this.props._onUpdateValue(this.props.path, (0, _utils.toNumber)(value));
6884+
this.props.onUpdate && this.props.onUpdate((0, _utils.toNumber)(value));
68856885
}
68866886
}, {
68876887
key: 'renderSlider',

build/react-dat-gui.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dev/src/App.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ class App extends Component {
8282
<div>
8383
<b>Number value:</b> {data.number}
8484
</div>
85+
<div>
86+
<b>Number value is a string:</b> {(typeof data.number === 'string') ? 'true' : 'false'}
87+
</div>
8588
<div>
8689
<b>Float value:</b> {data.float}
8790
</div>

dev/src/react-dat-gui/components/DatNumber.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ export default class DatNumber extends Component {
105105
update() {
106106
const { value } = this.state;
107107

108-
this.props._onUpdateValue && this.props._onUpdateValue(this.props.path, value);
109-
this.props.onUpdate && this.props.onUpdate(value);
108+
this.props._onUpdateValue && this.props._onUpdateValue(this.props.path, toNumber(value));
109+
this.props.onUpdate && this.props.onUpdate(toNumber(value));
110110
}
111111

112112
renderSlider(width) {

src/components/DatNumber.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ export default class DatNumber extends Component {
105105
update() {
106106
const { value } = this.state;
107107

108-
this.props._onUpdateValue && this.props._onUpdateValue(this.props.path, value);
109-
this.props.onUpdate && this.props.onUpdate(value);
108+
this.props._onUpdateValue && this.props._onUpdateValue(this.props.path, toNumber(value));
109+
this.props.onUpdate && this.props.onUpdate(toNumber(value));
110110
}
111111

112112
renderSlider(width) {

0 commit comments

Comments
 (0)