Skip to content

Commit 2883f5e

Browse files
committed
Reapply fix
1 parent 6c5b9a8 commit 2883f5e

File tree

1 file changed

+36
-23
lines changed

1 file changed

+36
-23
lines changed

jquery.minicolors.js

Lines changed: 36 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,6 @@
226226
});
227227
settings.swatches[i] = swatch;
228228
}
229-
230229
}
231230

232231
// Inline controls
@@ -235,7 +234,6 @@
235234
updateFromInput(input, false);
236235

237236
input.data('minicolors-initialized', true);
238-
239237
}
240238

241239
// Returns the input back to its original state
@@ -352,7 +350,6 @@
352350
updateFromControl(input, target);
353351
});
354352
}
355-
356353
}
357354

358355
// Sets the input based on the color picker values
@@ -703,7 +700,6 @@
703700
if(input.data('minicolors-initialized')) {
704701
doChange(input, value, opacity);
705702
}
706-
707703
}
708704

709705
// Runs the change and changeDelay callbacks
@@ -758,27 +754,36 @@
758754
}
759755
input.trigger('change').trigger('input');
760756
}
761-
762757
}
763758

764759
// Generates an RGB(A) object based on the input's value
765760
function rgbObject(input) {
766-
var hex = parseHex($(input).val(), true);
767-
var rgb = hex2rgb(hex);
768-
var opacity = $(input).attr('data-opacity');
769-
if(!rgb) return null;
770-
if(opacity !== undefined) $.extend(rgb, { a: parseFloat(opacity) });
761+
var rgb,
762+
opacity = $(input).attr('data-opacity');
763+
if( isRgb($(input).val()) ) {
764+
rgb = parseRgb($(input).val(), true);
765+
} else {
766+
var hex = parseHex($(input).val(), true);
767+
rgb = hex2rgb(hex);
768+
}
769+
if( !rgb ) return null;
770+
if( opacity !== undefined ) $.extend(rgb, { a: parseFloat(opacity) });
771771
return rgb;
772772
}
773773

774774
// Generates an RGB(A) string based on the input's value
775775
function rgbString(input, alpha) {
776-
var hex = parseHex($(input).val(), true);
777-
var rgb = hex2rgb(hex);
778-
var opacity = $(input).attr('data-opacity');
779-
if(!rgb) return null;
780-
if(opacity === undefined) opacity = 1;
781-
if(alpha) {
776+
var rgb,
777+
opacity = $(input).attr('data-opacity');
778+
if( isRgb($(input).val()) ) {
779+
rgb = parseRgb($(input).val(), true);
780+
} else {
781+
var hex = parseHex($(input).val(), true);
782+
rgb = hex2rgb(hex);
783+
}
784+
if( !rgb ) return null;
785+
if( opacity === undefined ) opacity = 1;
786+
if( alpha ) {
782787
return 'rgba(' + rgb.r + ', ' + rgb.g + ', ' + rgb.b + ', ' + parseFloat(opacity) + ')';
783788
} else {
784789
return 'rgb(' + rgb.r + ', ' + rgb.g + ', ' + rgb.b + ')';
@@ -814,13 +819,21 @@
814819
}
815820

816821
// Return RGBA object
817-
if(obj) {
818-
return {
819-
r: rgba[0],
820-
g: rgba[1],
821-
b: rgba[2],
822-
a: rgba[3] ? rgba[3] : null
823-
};
822+
if( obj ) {
823+
if (rgba[3]) {
824+
return {
825+
r: rgba[0],
826+
g: rgba[1],
827+
b: rgba[2],
828+
a: rgba[3]
829+
};
830+
} else {
831+
return {
832+
r: rgba[0],
833+
g: rgba[1],
834+
b: rgba[2]
835+
};
836+
}
824837
}
825838

826839
// Return RGBA string

0 commit comments

Comments
 (0)