Skip to content

Commit e67454f

Browse files
authored
[GPU][AMD] Fix lldb hipcc tests to link using libstdc++ (#69)
This commit changes the test Makefile.rules to force linking with libstdc++ when building with hipcc. An upstream [change](llvm#164462) modified the test link commands to add -nostdlib++ to avoid linking both the internal llvm c++ library and the external system c++ standard library. This was causing linking failures when building with hipcc because it expects to use the system libstdc++ library.
1 parent 068e826 commit e67454f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lldb/packages/Python/lldbsuite/test/make/Makefile.rules

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,13 @@ endif
107107
# Override CC and CXX when building a hip application.
108108
#
109109
# Use the same hipcc compiler for compiling and linking everything.
110+
# Make sure to link to the system standard library since hipcc needs it.
110111
#----------------------------------------------------------------------
111112
ifneq "$(strip $(HIP_SOURCES))" ""
112113
override CC := $(HIPCC)
113114
override CXX := $(HIPCC)
114115
override CC_TYPE := hip
116+
override USE_SYSTEM_STDLIB := 1
115117
endif
116118

117119
#----------------------------------------------------------------------

0 commit comments

Comments
 (0)