Skip to content

Commit 866718e

Browse files
committed
add test
1 parent 800d375 commit 866718e

File tree

1 file changed

+42
-0
lines changed

1 file changed

+42
-0
lines changed
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
import pytest
2+
3+
from tlm.utils.chat_completion_validation import _validate_chat_completion_params
4+
5+
6+
def test_validate_chat_completion_params_allows_valid_openai_keys() -> None:
7+
params = {"messages": [], "model": "gpt-4.1", "temperature": 0.5}
8+
9+
_validate_chat_completion_params(params, "openai")
10+
11+
12+
def test_validate_chat_completion_params_allows_provider_as_none() -> None:
13+
params = {"messages": [], "model": "gpt-4.1", "temperature": 0.5}
14+
15+
_validate_chat_completion_params(params, None)
16+
17+
18+
def test_validate_chat_completion_params_requires_messages() -> None:
19+
params = {"model": "gpt-4.1-mini"}
20+
21+
with pytest.raises(ValueError) as exc_info:
22+
_validate_chat_completion_params(params, "openai")
23+
24+
assert "openai_args must include the following parameter(s): messages" in str(exc_info.value)
25+
26+
27+
def test_validate_chat_completion_params_flags_invalid_keys() -> None:
28+
params = {"messages": [], "model": "gpt-4.1", "bad": True}
29+
30+
with pytest.raises(ValueError) as exc_info:
31+
_validate_chat_completion_params(params, "openai")
32+
33+
assert "Unsupported chat completion parameter(s) for provider openai: bad" in str(exc_info.value)
34+
35+
36+
def test_validate_chat_completion_params_allows_bedrock_only_keys() -> None:
37+
params = {"messages": [], "system": "Be helpful"}
38+
39+
_validate_chat_completion_params(params, "bedrock")
40+
41+
with pytest.raises(ValueError):
42+
_validate_chat_completion_params(params, "openai")

0 commit comments

Comments
 (0)