Skip to content

Commit 0c42ed6

Browse files
committed
test: skip tests that XMLSAXParser.warning on non Linux
Because it's not portable.
1 parent 1847bc9 commit 0c42ed6

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

test/test-xml-sax-parser.lua

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -949,6 +949,12 @@ function TestXMLSAXParser.test_warning()
949949
end
950950

951951
function TestXMLSAXParser.test_set_pedantic_as_option()
952+
if jit.os ~= "Linux" then
953+
-- parser.warning doesn't work because warningSAXFunc accepts
954+
-- variable length arguments.
955+
return
956+
end
957+
952958
local xml = [[
953959
<?xml version="1.0" encoding="UTF-8" ?>
954960
<!DOCTYPE root SYSTEM "file:///usr/local/share/test.dtd" [
@@ -1017,6 +1023,12 @@ local function collect_xml_errors(chunk)
10171023
end
10181024

10191025
function TestXMLSAXParser.test_xml_structured_error()
1026+
if jit.os ~= "Linux" then
1027+
-- parser.warning doesn't work because warningSAXFunc accepts
1028+
-- variable length arguments.
1029+
return
1030+
end
1031+
10201032
local xml = [[
10211033
<?xml version="1.0"?>
10221034
<id>&aaa;</id>

xmlua/xml-sax-parser.lua

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,8 @@ local function create_end_element_callback(user_callback)
267267
end
268268

269269
local function create_warning_callback(user_callback)
270+
-- This isn't portable because warningSAXFunc accepts variable
271+
-- length arguments.
270272
local callback = function(user_data,
271273
raw_warning_message,
272274
raw_string_value)

0 commit comments

Comments
 (0)