Update use bats setup and teardown features

Instead of relying on a custom global_setup and global_teardown
functions, migrate to the use of bats' setup_file and teardown_file
functions.

Signed-off-by: William Douglas <[email protected]>

Author: William Douglas

test/functional/3rd-party/3rd-party-allow-http.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME"
 	create_third_party_repo "$TEST_NAME" 10 staging my_repo
@@ -16,6 +16,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 test_teardown() {
 
 	sudo rm -rf "$TARGET_DIR"/etc/swupd

test/functional/3rd-party/3rd-party-bundle-info-basic.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME"
 	create_bundle -n test-bundle-upstream -f /file_upstream "$TEST_NAME"
@@ -26,6 +26,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR031: Show info about a 3rd-party bundle installed in the system" {
 
 	run sudo sh -c "$SWUPD 3rd-party bundle-info $SWUPD_OPTS test-bundle2"

test/functional/3rd-party/3rd-party-bundle-list-basic.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME"
 	create_bundle -n test-bundle-upstream -f /file_upstream "$TEST_NAME"
@@ -21,6 +21,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR018: List installed 3rd-party bundles" {
 
 	# When a user list 3rd-party bundles without specifiying a repo, all

test/functional/3rd-party/3rd-party-bundle-list-deps.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME"
 
@@ -22,6 +22,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR020: List dependencies of a 3rd-party bundle" {
 
 	run sudo sh -c "$SWUPD 3rd-party bundle-list $SWUPD_OPTS --deps test-bundle2"

test/functional/3rd-party/3rd-party-bundle-list-orphans.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME" 10 1
 	create_third_party_repo -a "$TEST_NAME" 10 1 repo1
@@ -20,6 +20,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR093: List orphaned 3rd-party bundles" {
 
 	run sudo sh -c "$SWUPD 3rd-party bundle-list $SWUPD_OPTS --orphans"

test/functional/3rd-party/3rd-party-check-update-basic.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME"
 
@@ -20,6 +20,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR053: Check for available updates on third party repos" {
 
 	run sudo sh -c "$SWUPD 3rd-party check-update $SWUPD_OPTS"

test/functional/3rd-party/3rd-party-diagnose-basic.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME" 10 1
 
@@ -32,6 +32,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR042: Diagnose shows modified files, new files and deleted files from 3rd-party bundles" {
 
 	run sudo sh -c "$SWUPD 3rd-party diagnose $SWUPD_OPTS"

test/functional/3rd-party/3rd-party-json-output-multirepo.bats

@@ -5,7 +5,7 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME"
 
@@ -16,6 +16,12 @@ global_setup() {
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR089: Using the --json-output flag with functions that run in multiple repos specifying a repo" {
 
 	run sudo sh -c "$SWUPD 3rd-party bundle-list $SWUPD_OPTS --json-output --repo repo1"

test/functional/3rd-party/3rd-party-repo-add-negative.bats

@@ -5,13 +5,19 @@
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	create_test_environment "$TEST_NAME"
 	create_third_party_repo "$TEST_NAME" 10 staging test-repo1
 
 }
 
+teardown_file() {
+
+	destroy_test_environment --force "$TEST_NAME"
+
+}
+
 @test "TPR003: Negative test, repo add usage" {
 
 	run sudo sh -c "$SWUPD 3rd-party add $SWUPD_OPTS"

test/functional/README.md

@@ -43,7 +43,7 @@ A new test script will be generated in the current directory.
 
 load "../testlib"
 
-global_setup() {
+setup_file() {
 
 	# global setup
 
@@ -61,7 +61,7 @@ test_teardown() {
 	# destroy_test_environment "$TEST_NAME"
 }
 
-global_teardown() {
+teardown_file() {
 
 	# global cleanup
 
@@ -83,7 +83,7 @@ global_teardown() {
 }
 ```
 
-4. The global_setup() function contains commands that are run only once per test
+4. The setup_file() function contains commands that are run only once per test
 script, it runs before any test in the script is executed.
 
 5. The test_setup() function contains commands that should be executed before every
@@ -106,7 +106,7 @@ if this is the case you can go ahead and remove the local test_teardown definiti
 test script so the pre-defined one is used, if you have more specific cleanup needs you will
 need to overwrite the function.
 
-7. The global_teardown() function contains commands that are run only once per test
+7. The teardown_file() function contains commands that are run only once per test
 script, it runs once all tests in the scripts have finished.
 
 8. Every test within the test file starts with the @test identifier followed