Rework clear linux docker container for test runs

Also skips a few tests that do not run well with docker (changing date
and disk filling have a hard time). Adding comment for how to run
docker (needs the --cap-add LINUX_IMMUTABLE option passed).

Signed-off-by: William Douglas <[email protected]>

Author: William Douglas

docker/Dockerfile

@@ -9,9 +9,17 @@
 #
 #
 
+# Build with the following:
+# docker build -t swupd-ci -f docker/Dockerfile .
+
 FROM clearlinux:latest
-ADD dockerrun.sh /dockerrun.sh
-ADD https://download.clearlinux.org/releases/13010/clear/Swupd_Root.pem /usr/share/clear/update-ca/Swupd_Root.pem
-RUN swupd update && swupd bundle-add os-core-update-dev sysadmin-basic os-testsuite c-basic
+RUN swupd bundle-add os-core-update-dev sysadmin-basic os-testsuite c-basic haskell-basic
+RUN pip install coverxygen && stack install ShellCheck && mv /root/.local/bin/shellcheck /usr/bin/
+RUN useradd tester && usermod -aG wheelnopw tester
+COPY . /build
+RUN chown -R tester /build
+USER tester
+WORKDIR /build
 
-CMD ["/dockerrun.sh"]
+# Requires docker run with: --cap-add LINUX_IMMUTABLE
+CMD ["/build/docker/dockerrun.sh"]

docker/dockerrun.sh

@@ -12,17 +12,6 @@
 # Enforce correct umask
 umask 0022
 
-mkdir -p /build
-cd /build
-
-if [[ ! -d /source ]]; then
-	echo "Missing source tree!" >&2
-	exit 1
-fi
-
-# Copy all the files across to prevent contaminating the bind mount
-cp -Ra /source/. /build
-
 die_fatal()
 {
 	echo "$*"
@@ -38,18 +27,27 @@ die_log_fatal()
 	fi
 	exit 1
 }
-
-jobCount="-j$(($(getconf _NPROCESSORS_ONLN)+1))"
+sudo chown -R tester .
 
 # Fix file permissions in the event of dodgy umask
 find test/functional -exec chmod g-w {} \;
 
 # Configure the build
 autoreconf --verbose --warnings=none --install --force || die_fatal "Configure failure"
-./configure || die_fatal "Configure failure"
-
-# Build error
-make $jobCount || die_fatal "Build failure"
 
-# Test suite failure, print the log
-make $jobCount check || die_log_fatal
+./configure CFLAGS="$CFLAGS -fsanitize=address -Werror" --prefix=/usr --with-fallback-capaths="$PWD"/swupd_test_certificates --with-systemdsystemunitdir=/usr/lib/systemd/system --with-config-file-path=./testconfig --enable-debug || die_fatal "Configure failure"
+
+make -j$(nproc) || die_fatal "Build Failure"
+make compliant || die_fatal "make compliant failure"
+make shellcheck-all || die_fatal "make shellcheck-all failure"
+make docs-coverage || die_fatal "make docs-coverage failure"
+sudo make install || die_fatal "make install failure"
+make install-check || die_fatal "make install-check failure"
+make check -j$(nproc) || die_fatal "unit test failure"
+make distcheck -j$(nproc) || die_fatal "make distcheck failure"
+./test/code_analysis/check_api_changes.bats || die_fatal "api change check failure"
+./scripts/github_actions/run_check.bash 1 1 || die_log_fatal
+FILES="$(find test/functional/only_in_ci_slow/ -name "*.bats")"
+env RUNNING_IN_CI=true TESTS="$(echo $FILES)" make -e check || die_log_fatal
+FILES="$(find test/functional/only_in_ci_system/ -name "*.bats")"
+env SKIP_DATE_CHECK=true SKIP_DISK_SPACE=true RUNNING_IN_CI=true TESTS="$(echo $FILES)" make -e check || die_log_fatal

test/functional/only_in_ci_system/add-no-disk-space.bats

@@ -7,6 +7,10 @@ load "../testlib"
 
 test_setup() {
 
+	if [ -n "${SKIP_DISK_SPACE}" ]; then
+		skip "Skipping disk space test"
+	fi
+
 	# create a test environment with 10 MB of space
 	create_test_environment -s 10 "$TEST_NAME"
 

test/functional/only_in_ci_system/expired-certificate-latest.bats

@@ -15,6 +15,9 @@ test_setup() {
 	if [ -z "${RUNNING_IN_CI}" ]; then
 		skip "Skipping slow test for local development, test only runs in CI"
 	fi
+	if [ -n "${SKIP_DATE_CHECK}" ]; then
+		skip "Skipping date test"
+	fi
 
 	create_test_environment "$TEST_NAME"
 	create_bundle -L -n test-bundle1 -f /file_1 "$TEST_NAME"

test/functional/only_in_ci_system/expired-certificate-mom.bats

@@ -15,6 +15,9 @@ test_setup() {
 	if [ -z "${RUNNING_IN_CI}" ]; then
 		skip "Skipping slow test for local development, test only runs in CI"
 	fi
+	if [ -n "${SKIP_DATE_CHECK}" ]; then
+		skip "Skipping date test"
+	fi
 
 	create_test_environment "$TEST_NAME"
 	create_bundle -L -n test-bundle1 -f /file_1 "$TEST_NAME"

test/functional/only_in_ci_system/expired-certificate.bats

@@ -15,6 +15,10 @@ test_setup() {
 	if [ -z "${RUNNING_IN_CI}" ]; then
 		skip "Skipping slow test for local development, test only runs in CI"
 	fi
+	if [ -n "${SKIP_DATE_CHECK}" ]; then
+		skip "Skipping date test"
+	fi
+
 	create_test_environment "$TEST_NAME"
 	create_bundle -n test-bundle -f /test-file "$TEST_NAME"
 

test/functional/only_in_ci_system/list-no-disk-space.bats

@@ -7,6 +7,10 @@ load "../testlib"
 
 test_setup() {
 
+	if [ -n "${SKIP_DISK_SPACE}" ]; then
+		skip "Skipping disk space test"
+	fi
+
 	# create a test environment with 10 MB of space
 	create_test_environment -s 10 "$TEST_NAME"
 

test/functional/only_in_ci_system/remove-no-disk-space.bats

@@ -7,6 +7,10 @@ load "../testlib"
 
 test_setup() {
 
+	if [ -n "${SKIP_DISK_SPACE}" ]; then
+		skip "Skipping disk space test"
+	fi
+
 	# create a test environment with 10 MB of space
 	create_test_environment -s 10 "$TEST_NAME"
 

test/functional/only_in_ci_system/repair-no-disk-space.bats

@@ -7,6 +7,10 @@ load "../testlib"
 
 test_setup() {
 
+	if [ -n "${SKIP_DISK_SPACE}" ]; then
+		skip "Skipping disk space test"
+	fi
+
 	# create a test environment with 10 MB of space
 	create_test_environment -s 10 "$TEST_NAME"
 

test/functional/only_in_ci_system/search-no-disk-space.bats

@@ -7,6 +7,10 @@ load "../testlib"
 
 test_setup() {
 
+	if [ -n "${SKIP_DISK_SPACE}" ]; then
+		skip "Skipping disk space test"
+	fi
+
 	# create a test environment with 10 MB of space
 	create_test_environment -s 3 "$TEST_NAME"