Switch to clang-format as a github action

Instead of having this be a local test, have a format target for the
Makefile and use a github action for clang-format to avoid differences
between developer systems clang-format and runner clang-format
versions.

Signed-off-by: William Douglas <[email protected]>

Author: William Douglas

.github/workflows/ccpp.yml

@@ -6,6 +6,17 @@ env:
    NUM_JOBS: 10
 
 jobs:
+  formatting-check:
+    name: Formatting Check
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Run clang-format style check
+      uses: jidicula/[email protected]
+      with:
+        clang-format-version: '16'
+        check-path: 'src'
+
   unit_and_style:
     runs-on: ubuntu-latest
     timeout-minutes: 60

Makefile.am

@@ -239,6 +239,9 @@ distclean-local:
 install-exec-hook:
 	perl $(top_srcdir)/scripts/findstatic.pl */*.o | grep -v Checking ||:
 
+format:
+	clang-format -i -style=file src/*.[ch] src/lib/*.[ch] src/3rd_party/*.[ch] src/cmds/*.[ch] src/swupd_lib/*.[ch] src/verifytime/*.[ch]
+
 compliant:
 	test/code_analysis/compliant.bats
 	test/functional/check_ids.bash

test/code_analysis/compliant.bats

@@ -24,18 +24,6 @@ check_sort_makefile()
 		return "$status"
 	fi
 
-	run clang-format -i -style=file src/*.[ch] src/lib/*.[ch] src/3rd_party/*.[ch] src/cmds/*.[ch] src/swupd_lib/*.[ch] src/verifytime/*.[ch]
-	if [ "$status" -ne 0 ]; then
-		echo "clang-format failed with status $status. Check if you have clang-format installed"
-		return "$status"
-	fi
-
-	run git diff --quiet --exit-code src
-	if [ "$status" -ne 0 ]; then
-		echo "Code style issues found. Run 'git diff' to view issues."
-		return "$status"
-	fi
-
 	run git grep if\ \(.*\)$ -- '*.c'
 	if [ "$status" -eq 0 ]; then
 		echo "Missing brackets in single line if:"