fix: Update code for dev dependency upgrades

- Rename eslint.config.js to eslint.config.mjs for ESM format (eslint 9.x)
- Add no-unused-vars exception for underscore-prefixed vars
- Replace chai-spies with sinon in dispatcherTests (chai-spies incompatible with chai v6)
- Add .default accessor for chai-as-promised in test files (ESM compatibility)
- Fix mockttp v4 flaky tests by adding delay between server stop/start

Author: JamieMagee

eslint.config.js

@@ -0,0 +1,23 @@
+import js from '@eslint/js'
+import globals from 'globals'
+import eslintConfigPrettier from 'eslint-config-prettier'
+
+export default [
+  js.configs.recommended,
+  {
+    languageOptions: {
+      globals: {
+        ...globals.node,
+        ...globals.mocha
+      },
+      parserOptions: {
+        sourceType: 'module'
+      }
+    },
+    rules: {
+      'no-console': 'off',
+      'no-unused-vars': ['error', { argsIgnorePattern: '^_', varsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }]
+    }
+  },
+  eslintConfigPrettier
+]

eslint.config.mjs

@@ -254,7 +254,7 @@ class Crawler {
         try {
           request = await self._releaseLock(request)
           request = await self._deleteFromQueue(request)
-        } catch (error) {
+        } catch (_error) {
           request = await self._abandonInQueue(request)
         }
       }

ghcrawler/lib/crawler.js

@@ -189,7 +189,7 @@ class CondaFetch extends AbstractFetch {
   async _fetchCachedJSONFile(cacheKey, url, cacheDuration, fileLocation) {
     try {
       await this._cachedDownload(cacheKey, url, cacheDuration, fileLocation)
-    } catch (error) {
+    } catch (_error) {
       return null
     }
     return JSON.parse(fs.readFileSync(fileLocation))

providers/fetch/condaFetch.js

@@ -33,7 +33,7 @@ class FetchDispatcher extends AbstractFetch {
       request.document = document
       request.contentOrigin = 'storage'
       return this._dispatchFetch(request)
-    } catch (error) {
+    } catch (_error) {
       // TODO eating the error here. at least log
       return this._fetchMissing(request)
     }

providers/fetch/dispatcher.js

@@ -11,9 +11,16 @@ function checkDefaultHeaders(headers) {
 }
 describe('CallFetch', () => {
   describe('with mock server', () => {
-    const mockServer = mockttp.getLocal()
-    beforeEach(async () => await mockServer.start())
-    afterEach(async () => await mockServer.stop())
+    let mockServer
+    beforeEach(async () => {
+      mockServer = mockttp.getLocal()
+      await mockServer.start()
+    })
+    afterEach(async () => {
+      await mockServer.stop()
+      // Small delay to ensure port is released before next test
+      await new Promise(resolve => setTimeout(resolve, 50))
+    })
 
     it('should return a stream when called with a URL string', async () => {
       const path = '/registry.npmjs.com/redis/0.1.0'

test/unit/lib/fetchTests.js

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 
 const chai = require('chai')
-const chaiAsPromised = require('chai-as-promised')
+const chaiAsPromised = require('chai-as-promised').default
 const {
   normalizePath,
   normalizePaths,

test/unit/lib/utilsTests.js

@@ -145,7 +145,7 @@ describe('Debian fetching', () => {
     try {
       await handler.handle(request)
       expect(false).to.be.true
-    } catch (error) {
+    } catch (_error) {
       expect(request.getTrackedCleanups().length).to.be.equal(2)
     }
   })

test/unit/providers/fetch/debianFetchTests.js

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: MIT
 
 const chai = require('chai')
-const spies = require('chai-spies')
 const sinon = require('sinon')
 const fs = require('fs')
 const PassThrough = require('stream').PassThrough
@@ -11,7 +10,6 @@ const proxyquire = require('proxyquire')
 const Request = require('../../../../ghcrawler').request
 const { promisify } = require('util')
 
-chai.use(spies)
 const expect = chai.expect
 
 const FetchDispatcher = require('../../../../providers/fetch/dispatcher')
@@ -30,10 +28,9 @@ describe('fetchDispatcher', () => {
   it('should call markNoSave if processor should not fetch', async () => {
     const processorsStub = [{ canHandle: () => true, shouldFetch: () => false }]
     const fetchDispatcher = FetchDispatcher({}, {}, {}, processorsStub)
-    const request = {}
-    chai.spy.on(request, 'markNoSave', () => {})
+    const request = { markNoSave: sinon.spy() }
     await fetchDispatcher.handle(request)
-    expect(request.markNoSave).to.have.been.called.once
+    expect(request.markNoSave.calledOnce).to.be.true
   })
 
   it('should markSkip request if missing from store and should not fetch missing', async () => {

test/unit/providers/fetch/dispatcherTests.js

@@ -51,7 +51,7 @@ describe('fetch result', () => {
     const request = new Request('licensee', 'cd:git/github/palantir/refreshable/2.0.0')
     try {
       await gitClient.handle(request)
-    } catch (error) {
+    } catch (_error) {
       expect(request.fetchResult).to.be.undefined
       expect(request.getTrackedCleanups().length).to.be.equal(1)
     }