Avoid network calls in dispatcherTests

Author: qtomlinson

test/fixtures/go/license.html

@@ -0,0 +1,22 @@
+<article>
+  <section class="License" id="lic-0">
+    <h2 class="go-textTitle">
+    <div id="#lic-0">Apache-2.0</div>
+    </h2>
+    <p>This is not legal advice. <a href="/license-policy">Read disclaimer.</a></p>
+    <pre class="License-contents">                                 Apache License
+                      Version 2.0, January 2004
+                    http://www.apache.org/licenses/
+    </pre>
+  </section>
+  <section class="License" id="lic-1">
+    <h2 class="go-textTitle">
+      <div id="#lic-1">BSD-2-Clause, BSD-3-Clause, HPND</div>
+    </h2>
+    <p>This is not legal advice. <a href="/license-policy">Read disclaimer.</a></p>
+    <pre class="License-contents">Copyright (c) 2013-2019 Tommi Virtanen.
+      Copyright (c) 2009, 2011, 2012 The Go Authors.
+      All rights reserved.
+    </pre>
+  </section>
+</article>

test/unit/providers/fetch/dispatcherTests.js

@@ -312,14 +312,22 @@ describe('fetchDispatcher cache fetch result', () => {
       return `/go/${fileName}`
     }
 
+    const httpContent = fs.readFileSync('test/fixtures/go/license.html')
+    const successHttpStub = {
+      get: sinon.stub().returns({
+        status: 200,
+        data: httpContent
+      })
+    }
+
     let fetchDispatcher
 
     beforeEach(() => {
       const GoFetch = proxyquire('../../../../providers/fetch/goFetch', {
         request: { get: createGetStub(fileSupplier) },
         'request-promise-native': createRequestPromiseStub(fileSupplier)
       })
-      const fetch = GoFetch({ logger: { info: sinon.stub() } })
+      const fetch = GoFetch({ logger: { info: sinon.stub() }, http: successHttpStub })
       fetchDispatcher = setupDispatcher(fetch)
     })
 
@@ -382,6 +390,7 @@ describe('fetchDispatcher cache fetch result', () => {
         'request-promise-native': sinon.stub().resolves(loadJson('pod/registryData.json'))
       })
       const fetch = PodFetch({ logger: { info: sinon.stub() } })
+      fetch._getPackage = sinon.stub().resolves('/tmp/cd-pYKk9q/SwiftLCS-1.0')
       fetchDispatcher = setupDispatcher(fetch)
     })
 

test/unit/providers/fetch/goFetchTests.js

@@ -69,34 +69,13 @@ describe('Go Proxy fetching', () => {
       response.end()
       return response
     }
+
+    const httpContent = fs.readFileSync('test/fixtures/go/license.html')
     successHttpStub = {
       get: sinon.stub().returns({
         status: 200,
-        data:
-          `<article>
-            <section class="License" id="lic-0">
-              <h2 class="go-textTitle">
-              <div id="#lic-0">Apache-2.0</div>
-              </h2>
-              <p>This is not legal advice. <a href="/license-policy">Read disclaimer.</a></p>
-              <pre class="License-contents">                                 Apache License
-                                Version 2.0, January 2004
-                              http://www.apache.org/licenses/
-              </pre>
-            </section>
-            <section class="License" id="lic-1">
-              <h2 class="go-textTitle">
-                <div id="#lic-1">BSD-2-Clause, BSD-3-Clause, HPND</div>
-              </h2>
-              <p>This is not legal advice. <a href="/license-policy">Read disclaimer.</a></p>
-              <pre class="License-contents">Copyright (c) 2013-2019 Tommi Virtanen.
-                Copyright (c) 2009, 2011, 2012 The Go Authors.
-                All rights reserved.
-              </pre>
-            </section>
-          </article>`
-      }
-      )
+        data: httpContent
+      })
     }
     Fetch = proxyquire('../../../../providers/fetch/goFetch', {
       request: { get: getStub },