chore(deps-dev): bump @biomejs/biome from 1.9.4 to 2.4.8 in the dev-dependencies group (#1504)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jamie Magee <jamie.magee@gmail.com>

Author: dependabot[bot]

bin/config.js

@@ -85,10 +85,10 @@ module.exports = {
     website: config.get('WEBSITE_ENDPOINT') || 'http://localhost:3000'
   },
   limits: {
-    windowSeconds: Number.parseInt(config.get('RATE_LIMIT_WINDOW')) || 1,
-    max: Number.parseInt(config.get('RATE_LIMIT_MAX')) || 0,
-    batchWindowSeconds: Number.parseInt(config.get('BATCH_RATE_LIMIT_WINDOW')) || 1,
-    batchMax: Number.parseInt(config.get('BATCH_RATE_LIMIT_MAX')) || 0
+    windowSeconds: Number.parseInt(config.get('RATE_LIMIT_WINDOW'), 10) || 1,
+    max: Number.parseInt(config.get('RATE_LIMIT_MAX'), 10) || 0,
+    batchWindowSeconds: Number.parseInt(config.get('BATCH_RATE_LIMIT_WINDOW'), 10) || 1,
+    batchMax: Number.parseInt(config.get('BATCH_RATE_LIMIT_MAX'), 10) || 0
   },
   webhook: {
     githubSecret:

biome.json

@@ -1,13 +1,14 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.4.8/schema.json",
   "files": {
-    "ignore": [
-      ".github/workflows/*",
-      ".vscode/launch.json",
-      ".nyc_output",
-      "schemas/*.json",
-      "test/**/*.json",
-      "test/**/*.yaml"
+    "includes": [
+      "**",
+      "!**/.github/workflows/**/*",
+      "!**/.vscode/launch.json",
+      "!**/.nyc_output",
+      "!**/schemas/**/*.json",
+      "!**/test/**/*.json",
+      "!**/test/**/*.yaml"
     ]
   },
   "formatter": {
@@ -28,22 +29,24 @@
     "rules": {
       "recommended": true,
       "suspicious": {
-        "noConsoleLog": "off",
         "noAssignInExpressions": "off",
         "noDoubleEquals": "off",
         "noGlobalIsNan": "off",
         "noExplicitAny": "off",
         "noDuplicateTestHooks": "off",
         "noConfusingVoidType": "off",
-        "noMisleadingInstantiator": "off"
+        "noMisleadingInstantiator": "off",
+        "noConsole": { "level": "off", "options": { "allow": ["log"] } },
+        "noVar": "off",
+        "useIterableCallbackReturn": "off"
       },
       "correctness": {
         "noUnusedVariables": "warn",
+        "noUnusedFunctionParameters": "off",
         "noInnerDeclarations": "off"
       },
       "style": {
         "noParameterAssign": "off",
-        "noVar": "off",
         "noUselessElse": "off",
         "useNodejsImportProtocol": "off",
         "useTemplate": "off",

business/aggregator.d.ts

@@ -3,7 +3,7 @@
 
 import type { EntityCoordinates } from '../lib/entityCoordinates'
 import type { Logger } from '../providers/logging'
-import type { Definition, DefinitionFile } from './definitionService'
+import type { Definition } from './definitionService'
 
 /**
  * Tool precedence configuration.

business/definitionService.js

@@ -929,7 +929,7 @@ class DefinitionService {
    * @private
    * @deprecated This method is currently unused
    */
-  // @ts-ignore - unused but kept for API compatibility
+  // @ts-expect-error - unused but kept for API compatibility
   _getDefinitionCoordinates(coordinates) {
     return Object.assign({}, coordinates, { tool: 'definition', toolVersion: 1 })
   }

lib/curation.js

@@ -100,7 +100,6 @@ class Curation {
    * @private
    */
   _validateSpdxCompliance() {
-    // @ts-ignore - data.revisions accessed after validation
     const revisions = this.data.revisions
     /** @type {{source: string, license: string}[]} */
     const sourceLicenseList = []

lib/fetch.js

@@ -81,13 +81,13 @@ async function callFetch(request, axiosInstance = axios) {
     const options = buildRequestOptions(request)
     const response = await axiosInstance(options)
     if (!request.resolveWithFullResponse) return response.data
-    // @ts-ignore - Adding custom properties to response object
+    // @ts-expect-error - Adding custom properties to response object
     response.statusCode = response.status
-    // @ts-ignore - Adding custom properties to response object
+    // @ts-expect-error - Adding custom properties to response object
     response.statusMessage = response.statusText
     return response
   } catch (error) {
-    // @ts-ignore - Adding statusCode property to error
+    // @ts-expect-error - Adding statusCode property to error
     error.statusCode = error.response?.status
     throw error
   }

lib/gradleCoordinatesMapper.d.ts

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 
 import type { EntityCoordinates, EntityCoordinatesSpec } from './entityCoordinates'
-import { FetchFunction, type FetchResponse } from './fetch'
+import { type FetchResponse } from './fetch'
 
 /** Coordinates specific to Gradle plugin resolution */
 export interface GradleCoordinates extends EntityCoordinatesSpec {

lib/rateLimit.d.ts

@@ -3,7 +3,6 @@
 
 import type { NextFunction, Request, Response } from 'express'
 import type { Store } from 'express-rate-limit'
-import { RedisClientType } from 'redis'
 import type { ICache } from '../providers/caching'
 import type { Logger } from '../providers/logging'
 

lib/utils.js

@@ -15,7 +15,6 @@ const EntityCoordinates = require('./entityCoordinates')
 const ResultCoordinates = require('./resultCoordinates')
 const { DateTime } = require('luxon')
 const { set, unset, union, sortBy, trim, uniqBy } = require('lodash')
-// @ts-ignore - extend module has no types
 const extend = require('extend')
 const SPDX = require('@clearlydefined/spdx')
 const scancodeMap = require('./scancodeMap')
@@ -211,7 +210,7 @@ function extractDate(dateAndTime) {
  */
 function compareDates(dateA, dateB) {
   if (!dateA || !dateB) return dateA ? 1 : dateB ? -1 : 0
-  // @ts-ignore - Date subtraction works in JavaScript
+  // @ts-expect-error - Date subtraction works in JavaScript
   return DateTime.fromISO(dateA).toJSDate() - DateTime.fromISO(dateB).toJSDate()
 }
 
@@ -556,9 +555,7 @@ function getLicenseLocations(coordinates, packages) {
     go: [goLicenseLocation(coordinates)],
     debsrc: packages ? debsrcLicenseLocations(packages) : []
   }
-  // @ts-ignore - dynamically adding sourcearchive property
   map.sourcearchive = map.maven
-  // @ts-ignore - dynamic key access
   return map[coordinates.type]
 }