Merge pull request #1510 from clearlydefined/enable-no-assign-in-expressions

Stop assigning inside expressions

Author: jamesiri

biome.json

@@ -29,7 +29,6 @@
     "rules": {
       "recommended": true,
       "suspicious": {
-        "noAssignInExpressions": "off",
         "noExplicitAny": "off",
         "noDuplicateTestHooks": "off",
         "noConsole": { "level": "off", "options": { "allow": ["log"] } },

providers/stores/azblobHarvestStore.js

@@ -141,7 +141,8 @@ class AzHarvestBlobStore extends AbstractAzBlobStore {
         if (!tool || !toolVersion) {
           return result
         }
-        const current = (result[tool] = result[tool] || {})
+        result[tool] = result[tool] || {}
+        const current = result[tool]
         current[toolVersion] = entry.content
         return result
       }, result)

providers/stores/fileHarvestStore.js

@@ -113,7 +113,8 @@ class FileHarvestStore extends AbstractFileStore {
     )
     return contents.reduce((result, entry) => {
       const { tool, toolVersion } = this._toResultCoordinatesFromStoragePath(entry.name)
-      const current = (result[tool] = result[tool] || {})
+      result[tool] = result[tool] || {}
+      const current = result[tool]
       current[toolVersion] = entry.content
       return result
     }, {})