Merge pull request #1409 from qtomlinson/qt/add_logging

Add logging to harvest filter initialization

Author: qtomlinson

providers/harvest/throttling/listBasedFilter.js

@@ -25,6 +25,11 @@ class ListBasedFilter {
     // Store as a Set for quick type lookup
     this._targetTypes = new Set(versionlessCoordinates.map(c => c.type))
     this._blacklist = new Set(versionlessCoordinates.map(c => c.toString()))
+    this.logger.info('ListBasedFilter initialized', {
+      blockedCount: this._blacklist.size,
+      blockedCoordinates: [...this._blacklist].sort(),
+      targetTypes: [...this._targetTypes].sort()
+    })
   }
 
   /**

test/providers/harvest/throttling/listBasedFilterConfigTest.js

@@ -6,14 +6,20 @@ const EntityCoordinates = require('../../../../lib/entityCoordinates')
 const proxyquire = require('proxyquire')
 
 describe('ListBasedFilterConfig', () => {
-  // Stub the logger used by the module to avoid initialization issues
-  const factory = proxyquire('../../../../providers/harvest/throttling/listBasedFilterConfig', {
-    '../../logging/logger': () => ({
-      debug: () => {},
-      error: () => {},
-      warn: () => {}
+  // Helper to create a factory with shared logger stub and optional overrides
+  const makeFactory = overrides =>
+    proxyquire('../../../../providers/harvest/throttling/listBasedFilterConfig', {
+      '../../logging/logger': () => ({
+        info: () => {},
+        debug: () => {},
+        error: () => {},
+        warn: () => {}
+      }),
+      ...(overrides || {})
     })
-  })
+
+  // Stub the logger used by the module to avoid initialization issues
+  const factory = makeFactory()
 
   function createCoord(coordString) {
     return EntityCoordinates.fromString(coordString)
@@ -85,14 +91,6 @@ describe('ListBasedFilterConfig', () => {
 
     describe('with mixed-type array', () => {
       it('filters out non-string entries and blocks only string coordinates', () => {
-        const factory = proxyquire('../../../../providers/harvest/throttling/listBasedFilterConfig', {
-          '../../logging/logger': () => ({
-            debug: () => {},
-            error: () => {},
-            warn: () => {}
-          })
-        })
-
         const mixed = JSON.stringify(['npm/npmjs/-/left-pad', 123, null, {}, 'git/github/org/name'])
         const filter = factory(mixed)
 
@@ -104,15 +102,10 @@ describe('ListBasedFilterConfig', () => {
 
     describe('environment config', () => {
       it('reads HARVEST_THROTTLER_BLACKLIST from config and blocks', () => {
-        const factoryFromEnv = proxyquire('../../../../providers/harvest/throttling/listBasedFilterConfig', {
+        const factoryFromEnv = makeFactory({
           'painless-config': {
             get: key => (key === 'HARVEST_THROTTLER_BLACKLIST' ? JSON.stringify(['git/github/org/name']) : undefined)
-          },
-          '../../logging/logger': () => ({
-            debug: () => {},
-            error: () => {},
-            warn: () => {}
-          })
+          }
         })
 
         const filter = factoryFromEnv()

test/providers/harvest/throttling/listBasedFilterTest.js

@@ -7,6 +7,7 @@ const EntityCoordinates = require('../../../../lib/entityCoordinates')
 
 describe('ListBasedFilter', () => {
   const logger = {
+    info: () => {},
     debug: () => {},
     error: () => {},
     warn: () => {}
@@ -116,6 +117,7 @@ describe('ListBasedFilter', () => {
       it('should log warnings for invalid coordinates', () => {
         const warnings = []
         const mockLogger = {
+          info: () => {},
           debug: () => {},
           error: () => {},
           warn: msg => warnings.push(msg)

test/routes/harvest.js

@@ -11,6 +11,7 @@ const utils = require('../../lib/utils')
 
 // Shared noop logger for tests
 const logger = {
+  info: () => {},
   debug: () => {},
   error: () => {},
   warn: () => {}