Skip to content

Commit 8081b67

Browse files
committed
chore: simplify workflows, do not run tests on full MSRV
1 parent a392da8 commit 8081b67

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
args: --all
6161

6262
msrv-check:
63-
name: MSRV check for Rust ${{ matrix.toolchain }} on ${{ matrix.os }}
63+
name: MSRV check on ${{ matrix.os }}
6464
strategy:
6565
fail-fast: false
6666
matrix:
@@ -95,21 +95,20 @@ jobs:
9595
run: just toolchain=${{ matrix.toolchain }} check-minimal
9696

9797
build:
98-
name: Build for Rust ${{ matrix.toolchain }} on ${{ matrix.os }}
98+
name: Build on ${{ matrix.os }}
9999
strategy:
100100
fail-fast: false
101101
matrix:
102-
toolchain: [ 1.68.2, stable ] # TODO: change 1.68.2 for your minimum supported Rust version
103102
os: [ ubuntu-24.04, macos-14, windows-2022 ]
104103
runs-on: ${{ matrix.os }}
105104
steps:
106105
- name: Checkout code
107106
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
108107

109-
- name: Install Rust ${{ matrix.toolchain }}
108+
- name: Install Rust
110109
uses: actions-rust-lang/setup-rust-toolchain@9d7e65c320fdb52dcd45ffaa68deb6c02c8754d9 # v1.12.0
111110
with:
112-
toolchain: ${{ matrix.toolchain }}
111+
toolchain: stable
113112
cache: false
114113

115114
- name: Rust Cache

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
with:
6666
bin: YOUR-BINS-HERE # TODO replace this with a comma-separated list of bins to publish
6767
token: ${{ secrets.GITHUB_TOKEN }}
68-
archive: $bin-$target-$tag # TODO if you have mulitiple bins, replace $bin here
68+
archive: $bin-$target-$tag # TODO if you have multiple bins, replace $bin here
6969
target: ${{ matrix.arch }}-${{ matrix.platform }}
7070
include: LICENSE,README.md
7171
leading-dir: true

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This guide is meant for people wishing to contribute to this open-source project
44

55
### Rust
66

7-
You need at least **Rust 1.68.2** (_TODO validate this minimum version_) to build this project's code and run the tests. You can install Rust from the [official website](https://www.rust-lang.org/tools/install).
7+
You need a Rust toolchain to build this project's code and run the tests. You can install Rust from the [official website](https://www.rust-lang.org/tools/install).
88
If you already have a version of Rust installed via `rustup` but it's too old, you can update by running
99

1010
```bash

justfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,11 @@ _check-minimal-only: (_rimraf "target/check-minimal-target")
139139
{{cargo}} minimal-versions check --target-dir target/check-minimal-target {{package_flag}} --lib --bins {{all_features_flag}} {{message_format_flag}}
140140

141141
# Run `cargo msrv` with `cargo minimal-versions check`
142-
msrv-minimal: (prep "--manifest-backup-suffix .msrv-prep.outer.bak") && (unprep "--manifest-backup-suffix .msrv-prep.outer.bak")
142+
msrv: (prep "--manifest-backup-suffix .msrv-prep.outer.bak") && (unprep "--manifest-backup-suffix .msrv-prep.outer.bak")
143143
{{cargo}} msrv find -- {{just}} _check-minimal-only
144144

145145
# Run `cargo msrv` with `cargo check`
146-
msrv *extra_args: (prep "--manifest-backup-suffix .msrv-prep.outer.bak --no-merge-pinned-dependencies") && (unprep "--manifest-backup-suffix .msrv-prep.outer.bak")
146+
msrv-full *extra_args: (prep "--manifest-backup-suffix .msrv-prep.outer.bak --no-merge-pinned-dependencies") && (unprep "--manifest-backup-suffix .msrv-prep.outer.bak")
147147
{{cargo}} msrv find -- {{just}} _msrv-check {{extra_args}}
148148

149149
_msrv-check *extra_args: (_rimraf "target/msrv-target") (check "--target-dir target/msrv-target" extra_args)
@@ -174,6 +174,6 @@ unprep *extra_args:
174174
@_rimraf-it target_dir:
175175
Remove-Item "{{target_dir}}" -Recurse
176176

177-
# Prints state of docker container to stdout
177+
# Prints state of a docker container to stdout
178178
@_check-container-state name:
179179
docker container ls --filter "name={{name}}" --format "{{{{.State}}"

0 commit comments

Comments
 (0)