refactor: add barrel to backend core/entity

clementvidon · clementvidon · commit 796bd7b70013 · 2025-10-06T22:32:44.000+02:00
diff --git a/backend/eslint.config.mjs b/backend/eslint.config.mjs
@@ -14,6 +14,31 @@ export default defineConfig([
     ignores: ['drizzle.config.ts'],
   },
   sharedConfig,
+  {
+    files: ['src/**/*.{ts,tsx}'],
+    rules: {
+      'no-restricted-imports': [
+        'error',
+        {
+          patterns: [
+            {
+              group: [
+                './entity/*',
+                '../entity/*',
+                '../../entity/*',
+                '../core/entity/*',
+                '../../core/entity/*',
+                '../../../core/entity/*',
+                '@/internal/core/entity/*',
+              ],
+              message:
+                'Import backend entities via the barrel (e.g. "../entity" or "../../core/entity").',
+            },
+          ],
+        },
+      ],
+    },
+  },
   {
     files: ['**/*.ts'],
     languageOptions: {
diff --git a/backend/src/cmd/replay.ts b/backend/src/cmd/replay.ts
@@ -5,7 +5,7 @@ import path from 'path';
 import { JsonSnapshotAdapter } from '../internal/adapter/driven/items/JsonSnapshotAdapter';
 import { OpenAIAdapter } from '../internal/adapter/driven/llm/OpenAIAdapter';
 import { PostgresAdapter } from '../internal/adapter/driven/persistence/PostgresAdapter';
-import type { Item } from '../internal/core/entity/Item';
+import type { Item } from '../internal/core/entity';
 import { makeReportingAgent } from '../internal/usecase/agent/makeReportingAgent';
 
 // - Dump Neon UI: { id?, date_created: "YYYY-MM-DD HH:mm:ss.SSS", data: { items: Item[] } }
diff --git a/backend/src/internal/adapter/driven/items/JsonSnapshotAdapter.ts b/backend/src/internal/adapter/driven/items/JsonSnapshotAdapter.ts
@@ -1,4 +1,4 @@
-import type { Item } from '../../../core/entity/Item';
+import type { Item } from '../../../core/entity';
 import type { ItemsProviderPort } from '../../../core/port/ItemsProviderPort';
 
 export class JsonSnapshotAdapter implements ItemsProviderPort {
diff --git a/backend/src/internal/adapter/driven/items/RedditItemsAdapter.ts b/backend/src/internal/adapter/driven/items/RedditItemsAdapter.ts
@@ -1,6 +1,6 @@
 import { z } from 'zod';
 import { filterByScore } from '../../../core/domain/items/filterByScore';
-import type { Item } from '../../../core/entity/Item';
+import type { Item } from '../../../core/entity';
 import type { FetchPort } from '../../../core/port/FetchPort';
 import type { ItemsProviderPort } from '../../../core/port/ItemsProviderPort';
 import { fetchWithRetry } from '../../../lib/http/fetchWithRetry';
diff --git a/backend/src/internal/core/domain/items/filterByScore.ts b/backend/src/internal/core/domain/items/filterByScore.ts
@@ -1,4 +1,4 @@
-import type { Item } from '../../entity/Item';
+import type { Item } from '../../entity';
 
 export function filterByScore(items: Item[], minScore = 0): Item[] {
   return items.filter((i) => i.score >= minScore);
diff --git a/backend/src/internal/core/domain/profiles/aggregateProfiles.test.ts b/backend/src/internal/core/domain/profiles/aggregateProfiles.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, test } from 'vitest';
-import type { EmotionProfile } from '../../entity/EmotionProfile';
+import type { EmotionProfile } from '../../entity';
 import { aggregateProfiles } from './aggregateProfiles';
 
 const fakeEmotionProfiles: EmotionProfile[] = [
diff --git a/backend/src/internal/core/domain/profiles/aggregateProfiles.ts b/backend/src/internal/core/domain/profiles/aggregateProfiles.ts
@@ -3,7 +3,7 @@ import type {
   EmotionProfile,
   EmotionScores,
   TonalityScores,
-} from '../../entity/EmotionProfile';
+} from '../../entity';
 
 const EMOTION_KEYS = [
   'anger',
diff --git a/backend/src/internal/core/domain/weights/MomentumWeightsStrategy.ts b/backend/src/internal/core/domain/weights/MomentumWeightsStrategy.ts
@@ -1,4 +1,4 @@
-import type { RelevantItem, WeightedItem } from '../../entity/Item';
+import type { RelevantItem, WeightedItem } from '../../entity';
 import type { WeightsPort } from '../../port/WeightsPort';
 import { capByPercentile } from './capByPercentile';
 import { computeMomentum } from './computeMomentum';
diff --git a/backend/src/internal/core/domain/weights/capByPercentile.ts b/backend/src/internal/core/domain/weights/capByPercentile.ts
@@ -1,4 +1,4 @@
-import type { WeightedItem } from '../../entity/Item';
+import type { WeightedItem } from '../../entity';
 import type { CapOptions } from './MomentumWeightsStrategy';
 
 export type WeightsCapReason =
diff --git a/backend/src/internal/core/domain/weights/computeMomentum.ts b/backend/src/internal/core/domain/weights/computeMomentum.ts
@@ -1,4 +1,4 @@
-import type { RelevantItem, WeightedItem } from '../../entity/Item';
+import type { RelevantItem, WeightedItem } from '../../entity';
 import type { MomentumOptions } from './MomentumWeightsStrategy';
 
 function isNew(prevRaw: number | undefined): boolean {
diff --git a/backend/src/internal/core/domain/weights/normalizeByMean.ts b/backend/src/internal/core/domain/weights/normalizeByMean.ts
@@ -1,4 +1,4 @@
-import type { WeightedItem } from '../../entity/Item';
+import type { WeightedItem } from '../../entity';
 import type { NormalizeOptions } from './MomentumWeightsStrategy';
 
 /**
diff --git a/backend/src/internal/core/domain/weights/sanitizeScores.ts b/backend/src/internal/core/domain/weights/sanitizeScores.ts
@@ -1,4 +1,4 @@
-import type { RelevantItem } from '../../entity/Item';
+import type { RelevantItem } from '../../entity';
 
 /**
  * Sanitize `score` fields in current and previous RelevantItems.
diff --git a/backend/src/internal/core/entity/index.ts b/backend/src/internal/core/entity/index.ts
@@ -0,0 +1,3 @@
+export * from './EmotionProfile';
+export * from './Item';
+export * from './Report';
diff --git a/backend/src/internal/core/port/ItemsProviderPort.ts b/backend/src/internal/core/port/ItemsProviderPort.ts
@@ -1,4 +1,4 @@
-import type { Item } from '../entity/Item';
+import type { Item } from '../entity';
 
 /**
  * Provides raw items for the pipeline.
diff --git a/backend/src/internal/core/port/QueryPort.ts b/backend/src/internal/core/port/QueryPort.ts
@@ -2,8 +2,7 @@ import type {
   AggregatedEmotionProfileDto,
   HeadlineDto,
 } from '@devbarometer/shared/dto';
-import type { EmotionProfile } from '../entity/EmotionProfile';
-import type { Report } from '../entity/Report';
+import type { EmotionProfile, Report } from '../entity';
 
 /**
  * Read-only query port for application-level snapshot data.
diff --git a/backend/src/internal/core/port/WeightsPort.ts b/backend/src/internal/core/port/WeightsPort.ts
@@ -1,4 +1,4 @@
-import type { RelevantItem, WeightedItem } from '../entity/Item';
+import type { RelevantItem, WeightedItem } from '../entity';
 
 /**
  * Compute weights for the given items.
diff --git a/backend/src/internal/core/types/PipelineSnapshot.ts b/backend/src/internal/core/types/PipelineSnapshot.ts
@@ -1,9 +1,11 @@
 import type {
   AggregatedEmotionProfile,
   EmotionProfile,
-} from '../../core/entity/EmotionProfile';
-import type { Item, RelevantItem, WeightedItem } from '../../core/entity/Item';
-import type { Report } from '../entity/Report';
+  Item,
+  RelevantItem,
+  Report,
+  WeightedItem,
+} from '../../core/entity';
 
 export type PipelineSnapshot = {
   id: string;
diff --git a/backend/src/internal/usecase/agent/ReportingAgent.test.ts b/backend/src/internal/usecase/agent/ReportingAgent.test.ts
@@ -1,6 +1,5 @@
 import { beforeEach, describe, expect, test, vi } from 'vitest';
-import type { Item, WeightedItem } from '../../core/entity/Item';
-import type { Report } from '../../core/entity/Report';
+import type { Item, Report, WeightedItem } from '../../core/entity';
 import type { ItemsProviderPort } from '../../core/port/ItemsProviderPort';
 import type { LlmPort } from '../../core/port/LlmPort';
 import type { PersistencePort } from '../../core/port/PersistencePort';
diff --git a/backend/src/internal/usecase/agent/ReportingAgent.ts b/backend/src/internal/usecase/agent/ReportingAgent.ts
@@ -1,5 +1,5 @@
 import { aggregateProfiles } from '../../core/domain/profiles/aggregateProfiles';
-import type { WeightedItem } from '../../core/entity/Item';
+import type { WeightedItem } from '../../core/entity';
 import type { AgentPort } from '../../core/port/AgentPort';
 import type { ItemsProviderPort } from '../../core/port/ItemsProviderPort';
 import type { LlmPort } from '../../core/port/LlmPort';
diff --git a/backend/src/internal/usecase/profiles/createProfiles.test.ts b/backend/src/internal/usecase/profiles/createProfiles.test.ts
@@ -1,6 +1,5 @@
 import { beforeEach, describe, expect, test, vi } from 'vitest';
-import type { EmotionProfile } from '../../core/entity/EmotionProfile';
-import type { WeightedItem } from '../../core/entity/Item';
+import type { EmotionProfile, WeightedItem } from '../../core/entity';
 import type { LlmMessage } from '../../core/port/LlmPort';
 import { createProfiles } from './createProfiles';
 
@@ -117,8 +116,16 @@ describe('createProfiles', () => {
         expect(res.source).toBe(fakeWeightedItems[index].source);
         expect(res.title).toBe(fakeWeightedItems[index].title);
         expect(res.weight).toBe(0);
-        expect(Object.values(res.emotions).every((v) => v === 0)).toBe(true);
-        expect(Object.values(res.tonalities).every((v) => v === 0)).toBe(true);
+        expect(
+          Object.values(res.emotions as Record<string, number>).every(
+            (v) => v === 0,
+          ),
+        ).toBe(true);
+        expect(
+          Object.values(res.tonalities as Record<string, number>).every(
+            (v) => v === 0,
+          ),
+        ).toBe(true);
       });
     });
   });
diff --git a/backend/src/internal/usecase/profiles/createProfiles.ts b/backend/src/internal/usecase/profiles/createProfiles.ts
@@ -1,6 +1,5 @@
 import pLimit from 'p-limit';
-import type { EmotionProfile } from '../../core/entity/EmotionProfile';
-import type { WeightedItem } from '../../core/entity/Item';
+import type { EmotionProfile, WeightedItem } from '../../core/entity';
 import type { LlmPort } from '../../core/port/LlmPort';
 import { makeEmotionMessages, makeTonalityMessages } from './messages';
 import { parseEmotionRaw } from './parseEmotion';
diff --git a/backend/src/internal/usecase/profiles/createReport.test.ts b/backend/src/internal/usecase/profiles/createReport.test.ts
@@ -1,7 +1,6 @@
 import type { Mock } from 'vitest';
 import { beforeEach, describe, expect, test, vi } from 'vitest';
-import type { AggregatedEmotionProfile } from '../../core/entity/EmotionProfile';
-import type { Report } from '../../core/entity/Report';
+import type { AggregatedEmotionProfile, Report } from '../../core/entity';
 import { createReport } from './createReport';
 
 const fakeLLMResponse = `
diff --git a/backend/src/internal/usecase/profiles/createReport.ts b/backend/src/internal/usecase/profiles/createReport.ts
@@ -1,10 +1,10 @@
 import { z } from 'zod';
-import type {
-  AggregatedEmotionProfile,
-  EmotionScores,
-} from '../../core/entity/EmotionProfile';
-import type { Report } from '../../core/entity/Report';
-import { WEATHER_EMOJIS } from '../../core/entity/Report';
+import {
+  type AggregatedEmotionProfile,
+  type EmotionScores,
+  type Report,
+  WEATHER_EMOJIS,
+} from '../../core/entity';
 import type { LlmMessage, LlmPort } from '../../core/port/LlmPort';
 import { stripCodeFences } from '../../lib/string/stripCodeFences';
 
diff --git a/backend/src/internal/usecase/profiles/messages.ts b/backend/src/internal/usecase/profiles/messages.ts
@@ -1,4 +1,4 @@
-import type { WeightedItem } from '../../core/entity/Item';
+import type { WeightedItem } from '../../core/entity';
 import type { LlmMessage } from '../../core/port/LlmPort';
 
 export function makeEmotionMessages(
diff --git a/backend/src/internal/usecase/profiles/parseEmotion.ts b/backend/src/internal/usecase/profiles/parseEmotion.ts
@@ -1,5 +1,5 @@
 import { z } from 'zod';
-import type { EmotionScores } from '../../core/entity/EmotionProfile';
+import type { EmotionScores } from '../../core/entity';
 import { stripCodeFences } from '../../lib/string/stripCodeFences';
 import { FALLBACK_EMOTIONS } from './policy';
 
diff --git a/backend/src/internal/usecase/profiles/parseTonality.ts b/backend/src/internal/usecase/profiles/parseTonality.ts
@@ -1,5 +1,5 @@
 import { z } from 'zod';
-import type { TonalityScores } from '../../core/entity/EmotionProfile';
+import type { TonalityScores } from '../../core/entity';
 import { stripCodeFences } from '../../lib/string/stripCodeFences';
 import { FALLBACK_TONALITIES } from './policy';
 
diff --git a/backend/src/internal/usecase/profiles/policy.ts b/backend/src/internal/usecase/profiles/policy.ts
@@ -1,7 +1,4 @@
-import type {
-  EmotionScores,
-  TonalityScores,
-} from '../../core/entity/EmotionProfile';
+import type { EmotionScores, TonalityScores } from '../../core/entity';
 import type { LlmRunOptions } from '../../core/port/LlmPort';
 
 export const CONCURRENCY = 1;
diff --git a/backend/src/internal/usecase/queries/ReportQueryService.ts b/backend/src/internal/usecase/queries/ReportQueryService.ts
@@ -2,8 +2,7 @@ import type {
   AggregatedEmotionProfileDto,
   HeadlineDto,
 } from '@devbarometer/shared';
-import type { EmotionProfile } from '../../core/entity/EmotionProfile';
-import type { Report } from '../../core/entity/Report';
+import type { EmotionProfile, Report } from '../../core/entity';
 import type { PersistencePort } from '../../core/port/PersistencePort';
 import type { QueryPort } from '../../core/port/QueryPort';
 import { getAggregatedProfiles } from './getAggregatedProfiles';
diff --git a/backend/src/internal/usecase/queries/getAggregatedProfiles.ts b/backend/src/internal/usecase/queries/getAggregatedProfiles.ts
@@ -2,7 +2,7 @@ import {
   AggregatedEmotionProfileDtoSchema,
   type AggregatedEmotionProfileDto,
 } from '@devbarometer/shared';
-import { type AggregatedEmotionProfile } from '../../core/entity/EmotionProfile';
+import { type AggregatedEmotionProfile } from '../../core/entity';
 
 import type { PersistencePort } from '../../core/port/PersistencePort';
 
diff --git a/backend/src/internal/usecase/queries/getLastProfiles.ts b/backend/src/internal/usecase/queries/getLastProfiles.ts
@@ -1,4 +1,4 @@
-import type { EmotionProfile } from '../../core/entity/EmotionProfile';
+import type { EmotionProfile } from '../../core/entity';
 import type { PersistencePort } from '../../core/port/PersistencePort';
 
 export async function getLastProfiles(
diff --git a/backend/src/internal/usecase/queries/getLastReport.ts b/backend/src/internal/usecase/queries/getLastReport.ts
@@ -1,4 +1,4 @@
-import type { Report } from '../../core/entity/Report';
+import type { Report } from '../../core/entity';
 import type { PersistencePort } from '../../core/port/PersistencePort';
 
 export async function getLastReport(
diff --git a/backend/src/internal/usecase/queries/getRelevantItemsBefore.ts b/backend/src/internal/usecase/queries/getRelevantItemsBefore.ts
@@ -1,4 +1,4 @@
-import type { RelevantItem } from '../../core/entity/Item';
+import type { RelevantItem } from '../../core/entity';
 import type { PersistencePort } from '../../core/port/PersistencePort';
 
 export async function getRelevantItemsBefore(
diff --git a/backend/src/internal/usecase/relevance/filterRelevantItems.ts b/backend/src/internal/usecase/relevance/filterRelevantItems.ts
@@ -1,5 +1,5 @@
 import pLimit from 'p-limit';
-import type { Item, RelevantItem } from '../../core/entity/Item';
+import type { Item, RelevantItem } from '../../core/entity';
 import type { LlmPort } from '../../core/port/LlmPort';
 import { makeRelevanceMessages } from './messages';
 import { parseRelevanceResult } from './parseResult';
diff --git a/backend/src/internal/usecase/relevance/messages.ts b/backend/src/internal/usecase/relevance/messages.ts
@@ -1,4 +1,4 @@
-import type { Item } from '../../core/entity/Item';
+import type { Item } from '../../core/entity';
 import type { LlmMessage } from '../../core/port/LlmPort';
 
 export function makeRelevanceMessages(

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { Item } from '../../../core/entity/Item';`
	`1`	`+import type { Item } from '../../../core/entity';`
`2`	`2`	`import type { ItemsProviderPort } from '../../../core/port/ItemsProviderPort';`
`3`	`3`
`4`	`4`	`export class JsonSnapshotAdapter implements ItemsProviderPort {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { Item } from '../../entity/Item';`
	`1`	`+import type { Item } from '../../entity';`
`2`	`2`
`3`	`3`	`export function filterByScore(items: Item[], minScore = 0): Item[] {`
`4`	`4`	`return items.filter((i) => i.score >= minScore);`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { RelevantItem, WeightedItem } from '../../entity/Item';`
	`1`	`+import type { RelevantItem, WeightedItem } from '../../entity';`
`2`	`2`	`import type { WeightsPort } from '../../port/WeightsPort';`
`3`	`3`	`import { capByPercentile } from './capByPercentile';`
`4`	`4`	`import { computeMomentum } from './computeMomentum';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { WeightedItem } from '../../entity/Item';`
	`1`	`+import type { WeightedItem } from '../../entity';`
`2`	`2`	`import type { CapOptions } from './MomentumWeightsStrategy';`
`3`	`3`
`4`	`4`	`export type WeightsCapReason =`