@@ -163,19 +163,22 @@ func (m *MariaDB) resolveAssets(assets []knowledge.AssetKey, registry *AssetRegi
163163
164164 stmt , err := tx .PrepareContext (context .Background (), "SELECT id FROM assets WHERE type = ? AND value = ?" )
165165 if err != nil {
166+ tx .Rollback ()
166167 return fmt .Errorf ("Unable to prepare statement: %v" , err )
167168 }
168169
169170 for _ , a := range assets {
170171 q , err := stmt .QueryContext (context .Background (), a .Type , a .Key )
171172 if err != nil {
173+ tx .Rollback ()
172174 return fmt .Errorf ("Unable to query asset %v: %v" , a , err )
173175 }
174176 defer q .Close ()
175177
176178 for q .Next () {
177179 var idx int64
178180 if err := q .Scan (& idx ); err != nil {
181+ tx .Rollback ()
179182 return fmt .Errorf ("Unable to retrieve id for %v: %v" , a , err )
180183 }
181184 registry .Set (knowledge .AssetKey (a ), idx )
@@ -223,10 +226,12 @@ INSERT INTO assets (type, value) VALUES (?, ?)`)
223226
224227 res , err := insertQuery .ExecContext (context .Background (), a .Type , a .Key )
225228 if err != nil {
229+ tx .Rollback ()
226230 return 0 , fmt .Errorf ("Unable to insert asset %v: %v" , a , err )
227231 }
228232 idx , err := res .LastInsertId ()
229233 if err != nil {
234+ tx .Rollback ()
230235 return 0 , fmt .Errorf ("Unable to retrieve last inserted ID: %v" , err )
231236 }
232237 registry .Set (knowledge .AssetKey (a ), idx )
@@ -262,6 +267,7 @@ func (m *MariaDB) upsertRelations(source string, relations []knowledge.Relation,
262267 q , err := tx .PrepareContext (context .Background (),
263268 "INSERT INTO relations (from_id, to_id, type, source) VALUES (?, ?, ?, ?)" )
264269 if err != nil {
270+ tx .Rollback ()
265271 return 0 , fmt .Errorf ("Unable to prepare relation insertion query: %v" , err )
266272 }
267273 defer q .Close ()
@@ -286,6 +292,7 @@ func (m *MariaDB) upsertRelations(source string, relations []knowledge.Relation,
286292 bar .Increment ()
287293 continue
288294 }
295+ tx .Rollback ()
289296 return 0 , fmt .Errorf ("Unable to insert relation %v (%d -> %d): %v" , r , idxFrom , idxTo , err )
290297 }
291298 bar .Increment ()
@@ -318,6 +325,7 @@ INNER JOIN assets a ON r.from_id = a.id
318325INNER JOIN assets b ON r.to_id = b.id
319326WHERE a.type = ? AND a.value = ? AND b.type = ? AND b.value = ? AND r.type = ? AND r.source = ?` )
320327 if err != nil {
328+ tx .Rollback ()
321329 return 0 , 0 , err
322330 }
323331 defer stmt .Close ()
@@ -326,11 +334,13 @@ WHERE a.type = ? AND a.value = ? AND b.type = ? AND b.value = ? AND r.type = ? A
326334 res , err := stmt .ExecContext (context .Background (),
327335 r .From .Type , r .From .Key , r .To .Type , r .To .Key , r .Type , source )
328336 if err != nil {
337+ tx .Rollback ()
329338 return 0 , 0 , fmt .Errorf ("Unable to detete relation %v: %v" , r , err )
330339 }
331340 bar .Increment ()
332341 rCount , err := res .RowsAffected ()
333342 if err != nil {
343+ tx .Rollback ()
334344 return 0 , 0 , fmt .Errorf ("Unable to count rows affected by relations deletion: %v" , err )
335345 }
336346 removedCount += rCount
@@ -342,11 +352,13 @@ DELETE a FROM assets a
342352WHERE id NOT IN (select from_id from relations)
343353AND id NOT IN (select to_id from relations)` )
344354 if err != nil {
355+ tx .Rollback ()
345356 return 0 , 0 , fmt .Errorf ("Unable to delete assets: %v" , err )
346357 }
347358
348359 removedAssetsCount , err := res .RowsAffected ()
349360 if err != nil {
361+ tx .Rollback ()
350362 return 0 , 0 , fmt .Errorf ("Unable to count rows affected by assets deletion: %v" , err )
351363 }
352364
0 commit comments