Skip to content

Commit 8c30ff2

Browse files
committed
Fix prepared statement leaks.
1 parent 25ab2d1 commit 8c30ff2

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

internal/database/mariadb.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ func (m *MariaDB) resolveAssets(sourceID int, assets []knowledge.AssetKey) ([]in
158158
if err != nil {
159159
return nil, fmt.Errorf("Unable to prepare statement: %v", err)
160160
}
161+
defer stmt.Close()
161162

162163
assetIDs := []int{}
163164
for _, a := range assets {
@@ -190,6 +191,7 @@ func (m *MariaDB) resolveSourceIDFromDB(sourceName string) (int, error) {
190191
if err != nil {
191192
return 0, err
192193
}
194+
defer r.Close()
193195

194196
var sourceID int
195197
for r.Next() {
@@ -309,6 +311,8 @@ WHERE s.name = ? AND r.type <> 'observed' AND (a.type <> 'source' AND b.type <>
309311
return err
310312
}
311313

314+
defer rows.Close()
315+
312316
for rows.Next() {
313317
var FromType, ToType, FromKey, ToKey, Type string
314318
if err := rows.Scan(&FromType, &FromKey, &ToType, &ToKey, &Type); err != nil {

0 commit comments

Comments
 (0)