Missing defer of the progress bar closing.

clems4ever · clems4ever · commit af2e2d796b21 · 2021-01-13T23:52:45.000+01:00
This potentially led to states in which old progress bars were always
showing up in the logs.
diff --git a/internal/database/mariadb.go b/internal/database/mariadb.go
@@ -324,6 +324,7 @@ func (m *MariaDB) removeRelations(sourceID int, relations []knowledge.Relation)
 		return 0, 0, err
 	}
 	bar := pb.StartNew(len(relations))
+	defer bar.Finish()
 	removedCount := int64(0)
 
 	stmt, err := tx.PrepareContext(context.Background(), `
@@ -352,7 +353,6 @@ WHERE a.type = ? AND a.value = ? AND b.type = ? AND b.value = ? AND r.type = ? A
 		}
 		removedCount += rCount
 	}
-	bar.Finish()
 
 	res, err := tx.ExecContext(context.Background(), `
 DELETE a FROM assets a

Original file line number	Diff line number	Diff line change
`@@ -324,6 +324,7 @@ func (m *MariaDB) removeRelations(sourceID int, relations []knowledge.Relation)`
`324`	`324`	`return 0, 0, err`
`325`	`325`	`}`
`326`	`326`	`bar := pb.StartNew(len(relations))`
	`327`	`+ defer bar.Finish()`
`327`	`328`	`removedCount := int64(0)`
`328`	`329`
`329`	`330`	stmt, err := tx.PrepareContext(context.Background(), `
`@@ -352,7 +353,6 @@ WHERE a.type = ? AND a.value = ? AND b.type = ? AND b.value = ? AND r.type = ? A`
`352`	`353`	`}`
`353`	`354`	`removedCount += rCount`
`354`	`355`	`}`
`355`		`- bar.Finish()`
`356`	`356`
`357`	`357`	res, err := tx.ExecContext(context.Background(), `
`358`	`358`	`DELETE a FROM assets a`