Skip to content

Commit 6d87e37

Browse files
committed
fix(clerk-js): Revert navigation changes from TaskChooseOrganization
1 parent 7c71d40 commit 6d87e37

File tree

5 files changed

+43
-47
lines changed

5 files changed

+43
-47
lines changed

.changeset/thick-dancers-battle.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@clerk/backend': minor
3+
---
4+
5+
Introducing `users.__experimental_passwordUntrusted` action

.changeset/yummy-geese-work.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@clerk/clerk-react': minor
3+
---
4+
5+
Expose `buildTasksUrl` parameters

packages/clerk-js/src/ui/components/SessionTasks/tasks/TaskChooseOrganization/ChooseOrganizationScreen.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -122,16 +122,8 @@ const MembershipPreview = (props: { organization: OrganizationResource }) => {
122122
try {
123123
await setActive({
124124
organization,
125-
navigate: async ({ session }) => {
126-
const task = session.currentTask;
127-
if (task && task.key !== 'choose-organization') {
128-
await navigate(
129-
clerk.buildTasksUrl({
130-
redirectUrl: redirectUrlComplete,
131-
}),
132-
);
133-
return;
134-
}
125+
navigate: async () => {
126+
// TODO(after-auth) ORGS-779 - Handle next tasks
135127
await navigate(redirectUrlComplete);
136128
},
137129
});

packages/clerk-js/src/ui/components/SessionTasks/tasks/TaskChooseOrganization/CreateOrganizationScreen.tsx

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useClerk, useOrganizationList } from '@clerk/shared/react';
1+
import { useOrganizationList } from '@clerk/shared/react';
22
import type { CreateOrganizationParams } from '@clerk/shared/types';
33

44
import { useEnvironment } from '@/ui/contexts';
@@ -22,7 +22,6 @@ type CreateOrganizationScreenProps = {
2222

2323
export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) => {
2424
const card = useCardState();
25-
const clerk = useClerk();
2625
const { navigate } = useRouter();
2726
const { redirectUrlComplete } = useTaskChooseOrganizationContext();
2827
const { createOrganization, isLoaded, setActive } = useOrganizationList({
@@ -61,16 +60,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
6160

6261
await setActive({
6362
organization,
64-
navigate: async ({ session }) => {
65-
const task = session.currentTask;
66-
if (task && task.key !== 'choose-organization') {
67-
await navigate(
68-
clerk.buildTasksUrl({
69-
redirectUrl: redirectUrlComplete,
70-
}),
71-
);
72-
return;
73-
}
63+
navigate: async () => {
64+
// TODO(after-auth) ORGS-779 - Handle next tasks
7465
await navigate(redirectUrlComplete);
7566
},
7667
});

packages/clerk-js/src/ui/components/SessionTasks/tasks/TaskResetPassword/index.tsx

Lines changed: 28 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -75,34 +75,37 @@ const TaskResetPasswordInternal = () => {
7575
};
7676

7777
const resetPassword = async () => {
78-
if (!clerk.user) {
79-
return;
80-
}
81-
passwordField.clearFeedback();
82-
confirmField.clearFeedback();
83-
try {
84-
await updatePasswordWithReverification(clerk.user, [
85-
{
86-
newPassword: passwordField.value,
87-
signOutOfOtherSessions: sessionsField.checked,
88-
},
89-
]);
90-
91-
// Handle the next task if it exists or redirect to the complete url
92-
const task = clerk.session?.currentTask;
93-
if (task && task.key !== 'reset-password') {
94-
await navigate(
95-
clerk.buildTasksUrl({
96-
redirectUrl: redirectUrlComplete,
97-
}),
98-
);
78+
await card.runAsync(async () => {
79+
if (!clerk.user) {
9980
return;
10081
}
10182

102-
await navigate(redirectUrlComplete);
103-
} catch (e) {
104-
return handleError(e, [passwordField, confirmField], card.setError);
105-
}
83+
passwordField.clearFeedback();
84+
confirmField.clearFeedback();
85+
try {
86+
await updatePasswordWithReverification(clerk.user, [
87+
{
88+
newPassword: passwordField.value,
89+
signOutOfOtherSessions: sessionsField.checked,
90+
},
91+
]);
92+
93+
// Handle the next task if it exists or redirect to the complete url
94+
const task = clerk.session?.currentTask;
95+
if (task && task.key !== 'reset-password') {
96+
await navigate(
97+
clerk.buildTasksUrl({
98+
redirectUrl: redirectUrlComplete,
99+
}),
100+
);
101+
return;
102+
}
103+
104+
await navigate(redirectUrlComplete);
105+
} catch (e) {
106+
return handleError(e, [passwordField, confirmField], card.setError);
107+
}
108+
});
106109
};
107110

108111
const identifier = clerk.user?.primaryEmailAddress?.emailAddress ?? clerk.user?.username;

0 commit comments

Comments
 (0)