fix(upgrade): Remove unused getMajorVersion function (#5138)

Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>

Author: LekoArts

.changeset/tiny-moose-appear.md

@@ -0,0 +1,5 @@
+---
+'@clerk/upgrade': patch
+---
+
+Remove an internal function that was executed but its return value wasn't used. In some instances this function threw an error.

packages/upgrade/src/app.js

@@ -6,7 +6,6 @@ import { Header } from './components/Header.js';
 import { Scan } from './components/Scan.js';
 import { SDKWorkflow } from './components/SDKWorkflow.js';
 import SDKS from './constants/sdks.js';
-import { getClerkMajorVersion } from './util/get-clerk-version.js';
 import guessFrameworks from './util/guess-framework.js';
 
 /**
@@ -34,15 +33,13 @@ export default function App(props) {
   const [sdkGuessConfirmed, setSdkGuessConfirmed] = useState(false);
   const [sdkGuessAttempted, setSdkGuessAttempted] = useState(false);
   const [fromVersion, setFromVersion] = useState(props.fromVersion);
-  const [fromVersionGuessAttempted, setFromVersionGuessAttempted] = useState(false);
 
   const [toVersion, setToVersion] = useState(props.toVersion);
   const [dir, setDir] = useState(props.dir);
   const [ignore, setIgnore] = useState(props.ignore ?? []);
   const [configComplete, setConfigComplete] = useState(false);
   const [configVerified, setConfigVerified] = useState(false);
   const [uuid, setUuid] = useState();
-  let fromVersionGuess = false;
 
   if (yolo) {
     setSdks(SDKS.map(s => s.value));
@@ -77,12 +74,6 @@ export default function App(props) {
     setSdkGuessAttempted(true);
   }
 
-  // We try to guess which version of Clerk they are using
-  if (isEmpty(sdks) && !fromVersion && !fromVersionGuess && !fromVersionGuessAttempted) {
-    fromVersionGuess = getClerkMajorVersion();
-    setFromVersionGuessAttempted(true);
-  }
-
   // No support for v3 or below, sadly
   if (parseInt(fromVersion) < 4) {
     return <Text color='red'>We're so sorry, but this tool only supports migration from version 4 and above.</Text>;

packages/upgrade/src/util/get-clerk-version.js

@@ -1,12 +1,6 @@
 import { readPackageSync } from 'read-pkg';
 import semverRegex from 'semver-regex';
 
-export function getClerkMajorVersion() {
-  const pkg = readPackageSync();
-  const clerk = pkg.dependencies.clerk;
-  return clerk ? semverRegex().exec(clerk)[0][0] : false;
-}
-
 export function getClerkSdkVersion(sdk) {
   const pkg = readPackageSync();
   const clerkSdk = pkg.dependencies[`@clerk/${sdk}`];