Skip to content

Commit 90b2f72

Browse files
committed
Fix E2E test for sign-up with tasks
1 parent c356053 commit 90b2f72

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

integration/tests/session-tasks-sign-up.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
7373
await u.po.signUp.enterTestOtpCode();
7474

7575
// Resolves task
76-
await u.po.signIn.waitForMounted();
76+
await u.po.signUp.waitForMounted();
7777
const fakeOrganization = Object.assign(u.services.organizations.createFakeOrganization(), {
7878
slug: u.services.organizations.createFakeOrganization().slug + '-with-sign-in-sso',
7979
});

packages/clerk-js/src/ui/components/SignIn/shared.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { useClerk } from '@clerk/shared/react';
33
import { useCallback, useEffect } from 'react';
44

55
import { useCardState } from '@/ui/elements/contexts';
6-
import { useRouter } from '@/ui/router';
76
import { handleError } from '@/ui/utils/errorHandler';
87

98
import { clerkInvalidFAPIResponse } from '../../../core/errors';
@@ -16,9 +15,8 @@ function useHandleAuthenticateWithPasskey(onSecondFactor: () => Promise<unknown>
1615
// @ts-expect-error -- private method for the time being
1716
const { setActive, __internal_navigateWithError } = useClerk();
1817
const supportEmail = useSupportEmail();
19-
const { afterSignInUrl, signInUrl, navigateOnSetActive } = useSignInContext();
18+
const { afterSignInUrl, navigateOnSetActive } = useSignInContext();
2019
const { authenticateWithPasskey } = useCoreSignIn();
21-
const { navigate } = useRouter();
2220

2321
useEffect(() => {
2422
return () => {

packages/clerk-js/src/ui/contexts/components/SignIn.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export const SignInContext = createContext<SignInCtx | null>(null);
3737

3838
export const useSignInContext = (): SignInContextType => {
3939
const context = useContext(SignInContext);
40-
const { navigate, indexPath } = useRouter();
40+
const { navigate, basePath } = useRouter();
4141
const { displayConfig, userSettings } = useEnvironment();
4242
const { queryParams, queryString } = useRouter();
4343
const signUpMode = userSettings.signUp.mode;
@@ -126,7 +126,7 @@ export const useSignInContext = (): SignInContextType => {
126126
return navigate(redirectUrl);
127127
}
128128

129-
return navigate(indexPath + `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[currentTask.key]}`);
129+
return navigate(`/${basePath}/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[currentTask.key]}`);
130130
};
131131

132132
const taskUrl = clerk.session?.currentTask

packages/clerk-js/src/ui/contexts/components/SignUp.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const SignUpContext = createContext<SignUpCtx | null>(null);
3636

3737
export const useSignUpContext = (): SignUpContextType => {
3838
const context = useContext(SignUpContext);
39-
const { navigate, indexPath } = useRouter();
39+
const { navigate, basePath } = useRouter();
4040
const { displayConfig, userSettings } = useEnvironment();
4141
const { queryParams, queryString } = useRouter();
4242
const signUpMode = userSettings.signUp.mode;
@@ -121,7 +121,7 @@ export const useSignUpContext = (): SignUpContextType => {
121121
return navigate(redirectUrl);
122122
}
123123

124-
return navigate(indexPath + `/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[currentTask.key]}`);
124+
return navigate(`/${basePath}/tasks/${INTERNAL_SESSION_TASK_ROUTE_BY_KEY[currentTask.key]}`);
125125
};
126126

127127
const taskUrl = clerk.session?.currentTask

0 commit comments

Comments
 (0)