Create fresh SignIn on authenticateWithRedirect call

Author: LauraBeatris

packages/clerk-js/src/core/resources/SignIn.ts

@@ -227,21 +227,31 @@ export class SignIn extends BaseResource implements SignInResource {
   public authenticateWithRedirect = async (params: AuthenticateWithRedirectParams): Promise<void> => {
     const { strategy, redirectUrl, redirectUrlComplete, identifier } = params || {};
 
-    const { firstFactorVerification } =
-      (strategy === 'saml' || strategy === 'enterprise_sso') && this.id
-        ? await this.prepareFirstFactor({
-            strategy,
-            redirectUrl: SignIn.clerk.buildUrlWithAuth(redirectUrl),
-            actionCompleteRedirectUrl: redirectUrlComplete,
-          })
-        : await this.create({
-            strategy,
-            identifier,
-            redirectUrl: SignIn.clerk.buildUrlWithAuth(redirectUrl),
-            actionCompleteRedirectUrl: redirectUrlComplete,
-          });
-
-    const { status, externalVerificationRedirectURL } = firstFactorVerification;
+    /**
+     * Covers the case of custom flows, where `authenticateWithRedirect` gets called
+     * with a different identifier and the client already has a previous sign in attempty
+     *
+     * We shouldn't always create a fresh sign-in here since AIO components
+     * currently perform this before `authenticateWithRedirect`
+     */
+    if (this.id && identifier !== this.identifier) {
+      await this.create({
+        strategy,
+        identifier,
+        redirectUrl: SignIn.clerk.buildUrlWithAuth(redirectUrl),
+        actionCompleteRedirectUrl: redirectUrlComplete,
+      });
+    }
+
+    if (strategy === 'saml' || strategy === 'enterprise_sso') {
+      await this.prepareFirstFactor({
+        strategy,
+        redirectUrl: SignIn.clerk.buildUrlWithAuth(redirectUrl),
+        actionCompleteRedirectUrl: redirectUrlComplete,
+      });
+    }
+
+    const { status, externalVerificationRedirectURL } = this.firstFactorVerification;
 
     if (status === 'unverified' && externalVerificationRedirectURL) {
       windowNavigate(externalVerificationRedirectURL);